56649[TASK] Fix UTF-8 spelling in examples + documentation
Commit message
Review
-
Code review CR +2
- Frank Nägler +2
- Mathias Schreiber +1
-
Verified V +2
- Frank Nägler +2
- Mathias Schreiber +1
- TYPO3com +1 CI
Issues 1
Files 2
Review log 911
-
Michael Stucki uploaded patch set 1 04/13/18, 15:00
-
TYPO3com voted on patch set 1 V +1 04/13/18, 15:10 Completed build in 10m 01s on Fri, 13 Apr, 05:10 PM Test Summary: 30948 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-22307
-
Benni Mack commented on patch set 1 04/13/18, 15:42
Hey Michi, I think there are Ubuntu versions having "utf8" instead of "utf-8" used - but I have to look into it . https://help.ubuntu.com/community/Locale -
Michael Stucki commented on patch set 1 04/13/18, 16:25
Hi Benni, as far as I know "utf8" is an alias for "UTF-8", however then it's not written in upper-case. -
Benni Mack commented on patch set 1 04/15/18, 10:19
OK. thanks for the explanation Michi. Apart from that - the composer.lock change can't be done, as this comes from our dependency "php-cs-fixer" which has the wrong spelling. -
Michael Stucki uploaded patch set 2 04/15/18, 14:28
-
Michael Stucki commented on patch set 2 04/15/18, 14:29
Thanks for the feedback, Benni. I removed it from the patch. -
TYPO3com voted on patch set 2 V +1 04/15/18, 14:37 Completed build in 08m 15s on Sun, 15 Apr, 04:37 PM Test Summary: 30950 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-22366
-
Mathias Schreiber voted on patch set 2 V +1 CR +1 04/15/18, 16:33
-
Frank Nägler voted on patch set 2 V +2 CR +2 04/15/18, 16:35
-
Frank Nägler merged patch set 3 04/15/18, 16:35