Review TYPO3_8-7 Merged

56665[BUGFIX] Finishers with output must return the output

Stefan Neufeind CR +2 V +2 Easy +19 −7 updated 04/30/18, 15:53

Commit message

Since #83822 EXT:form makes usage of the controller context
response object which has impacts to the finisher logic which was not
treated by #83822.
Now, finishers with output can return this as string instead of setting
this directly into the response (which results in a double output).

Review

  • Code review CR +2
    • Stefan Neufeind +2
  • Verified V +2
    • Stefan Neufeind +2

Issues 1

Files 4

Review log 57

  1. Stefan Neufeind uploaded patch set 1 04/15/18, 08:33

  2. Stefan Neufeind uploaded patch set 2 04/15/18, 08:34

  3. TYPO3com voted on patch set 1 V +1 04/15/18, 08:44 Completed build in 10m 51s on Sun, 15 Apr, 10:44 AM Test Summary: 58267 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC87-2269

  4. Stefan Neufeind commented on patch set 2 V +2 CR +2 04/15/18, 08:47

    hand-picked due to difference in ConfirmationFinisher; but relevant code stays basically the same retested on 8.7
  5. Stefan Neufeind merged patch set 3 04/15/18, 08:47

  6. TYPO3com voted on patch set 2 V +1 04/15/18, 08:49 Completed build in 14m 57s on Sun, 15 Apr, 10:49 AM Test Summary: 58267 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC87-2270

  7. Frank Nägler commented on patch set 3 04/30/18, 15:53

    post -1 because of a regression in v8: https://forge.typo3.org/issues/84901