Review main Abandoned

56670[BUGFIX] Correct handling of group field values by InlineControlContainer

Franz Koch CR 0 V 0 Easy +3 −12 updated 10/11/18, 12:23

Commit message

The TcaGroup FormDataProvider now converts the group field value into
an array, just like it's the case for select fields.

Review

  • Code review CR 0
  • Verified V 0

Issues 1

Files 1

Review log 79

  1. Franz Koch uploaded patch set 1 04/15/18, 15:10

  2. Sybille Peters commented on patch set 1 04/15/18, 15:16

    Thanks for supplying the patch. Just one small thing: is the commented out @todo obsolete now? If yes you might want to remove that for more clarity?
  3. TYPO3com voted on patch set 1 V +1 04/15/18, 15:20 Completed build in 09m 55s on Sun, 15 Apr, 05:20 PM Test Summary: 30950 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-22367

  4. Mathias Schreiber updated the commit message in patch set 2 04/15/18, 15:27

  5. TYPO3com voted on patch set 2 V +1 04/15/18, 15:37 Completed build in 10m 02s on Sun, 15 Apr, 05:38 PM Test Summary: 30950 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-22368

  6. Christian Kuhn commented on patch set 2 10/10/18, 13:24

    https://review.typo3.org/#/c/58421/ comes with a similar solution.
  7. Christian Kuhn commented on patch set 2 10/10/18, 13:57

    thanks to cyril, this is now testable with "inline mngroup" in styleguide git master.
  8. Christian Kuhn commented on patch set 2 10/11/18, 12:21

    Hey Franz. Thanks for your patch. I'm sorry we did not pick this one up earlier, we should do FormEngine fixing more often. Meanwhile, another person pushed a similar patch on the same issue, and that one was actually picked up and worked on, so this one is a duplicate ... I hope it is ok with you if i just abandon your approach for the time being since we're dealing with that issue in https://review.typo3.org/#/c/58421/
  9. Anja Leichsenring abandoned the change 10/11/18, 12:23

    see message from Christian above