Review TYPO3_8-7 Merged

56672[BUGFIX] Fix getPublicUrl return hints

Jigal van Hemert CR +2 V +2 Easy +15 −10 updated 04/15/18, 21:47

Commit message

Since getPublicUrl could also return null, we need to
change the return hints to respect that.

Review

  • Code review CR +2
    • Jigal van Hemert +2
  • Verified V +2
    • Jigal van Hemert +2
    • TYPO3com +1 CI

Issues 1

Files 10

Review log 34

  1. Jigal van Hemert commented on patch set 1 04/15/18, 20:50

    Cherry Picked from branch master.
  2. Jigal van Hemert commented on patch set 1 V +2 CR +2 04/15/18, 20:52

    No code changes in this area between branches.
  3. TYPO3com voted on patch set 1 V +1 04/15/18, 21:00 Completed build in 10m 07s on Sun, 15 Apr, 11:00 PM Test Summary: 58269 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC87-2284

  4. Jigal van Hemert merged patch set 2 04/15/18, 21:47