56689[BUGFIX] Try to translate given help text of select items
Commit message
Review
-
Code review CR +2
- Wouter Wolters +2
- Anja Leichsenring +1
- Mona Muzaffar +1
-
Verified V +2
- Wouter Wolters +2
- Anja Leichsenring +1
- Mona Muzaffar +1
- TYPO3com +1 CI
Issues 1
Files 1
Review log 1215
-
Georg Ringer uploaded patch set 1 04/16/18, 14:41
-
Georg Tiefenbrunn voted on patch set 1 CR +1 04/16/18, 14:44
-
TYPO3com voted on patch set 1 V -1 04/16/18, 14:49 Completed build in 07m 53s on Mon, 16 Apr, 04:49 PM Test Summary: 3 of 31102 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-22412
-
Georg Ringer uploaded patch set 2 04/16/18, 15:25
-
TYPO3com voted on patch set 2 V +1 04/16/18, 15:38 Completed build in 12m 31s on Mon, 16 Apr, 05:38 PM Test Summary: 30950 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-22417
-
Mathias Schreiber commented on patch set 2 04/16/18, 15:43
I don't see any differences in rendering. Do I need to adjust the TCA of EXT:styleguide here? -
Mathias Schreiber commented on patch set 2 V +1 CR +1 04/17/18, 21:09
To the soul trying to text this later: https://github.com/TYPO3/styleguide/issues/112 helps :) -
Kay Strobach commented on patch set 2 CR -1 04/18/18, 08:23
AbstractItemProvider.php:1300please do not nest the ? conditions, may introduce errors by lazy reading as you miss parts of the condition. IMHO it makes sense to have it split into 2 conditions -
Anja Leichsenring uploaded patch set 3 06/01/18, 16:31
-
Anja Leichsenring voted on patch set 3 V +1 CR +1 06/01/18, 16:31
-
Mona Muzaffar voted on patch set 3 V +1 CR +1 06/01/18, 16:31
-
TYPO3com voted on patch set 3 V +1 06/01/18, 16:39 Completed build in 08m 37s on Fri, 1 Jun, 06:39 PM Test Summary: 31117 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-24002
-
Anja Leichsenring commented on patch set 3 06/01/18, 17:01
the related Pull Request to ext:styleguide is pending at https://github.com/TYPO3/styleguide/pull/113 -
Wouter Wolters voted on patch set 3 V +2 CR +2 06/02/18, 09:34
-
Wouter Wolters merged patch set 4 06/02/18, 09:34