Review main Merged

56691[TASK] Sort languages of field typo3Language in Site Management

Georg Ringer CR +2 V +2 Easy +3 −0 updated 04/25/18, 08:37

Commit message

Sort the languages by its name instead of identifier.

Review

  • Code review CR +2
    • Benni Mack +2
    • Kay Strobach +1
    • Frans Saris +1
  • Verified V +2
    • Benni Mack +2
    • Kay Strobach +1
    • TYPO3com +1 CI

Issues 1

Files 2

Review log 1114

  1. Georg Ringer uploaded patch set 1 04/16/18, 16:02

  2. TYPO3com voted on patch set 1 V -1 04/16/18, 16:10 Completed build in 08m 38s on Mon, 16 Apr, 06:10 PM Test Summary: 1 of 31102 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-22423

  3. TYPO3com commented on patch set 1 04/16/18, 16:24 Completed build in 31m 01s on Mon, 16 Apr, 06:24 PM Test Summary: 1 of 31102 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-22423

  4. TYPO3com voted on patch set 1 V +1 04/16/18, 16:36 Completed build in 1h 05m 06s on Mon, 16 Apr, 06:36 PM Test Summary: 30950 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-22423

  5. Frans Saris commented on patch set 1 04/16/18, 16:45

    sys_site_language.php:139

    Where is this for?
  6. Kay Strobach commented on patch set 1 CR -1 04/18/18, 15:39

    just asking the same question as frans
  7. Georg Ringer commented on patch set 1 04/19/18, 05:38

    sys_site_language.php:139 Reply

    so that on initial the "en" is selected which has the value "default" ;)
  8. Benni Mack commented on patch set 1 04/25/18, 04:13

    sys_site_language.php:139 Reply Unresolved

    @Frans: This is the original "config.language = ... " typoScript option, when you want english, you need "default" which is used for the locallang / XLF functionality.
  9. Benni Mack voted on patch set 1 CR +1 04/25/18, 04:13

  10. Frans Saris voted on patch set 1 CR +1 04/25/18, 05:13

  11. Benni Mack voted on patch set 1 V +1 04/25/18, 05:42

  12. Kay Strobach voted on patch set 1 V +1 CR +1 04/25/18, 06:18

  13. Benni Mack voted on patch set 1 V +2 CR +2 04/25/18, 08:37

  14. Benni Mack merged patch set 2 04/25/18, 08:37