Review TYPO3_8-7 Merged

56696[BUGFIX] Move file extension detection to FAL driver

Markus Klein CR +2 V +2 Easy +21 −8 updated 04/16/18, 21:09

Commit message

The only object that is allowed to handle the physical file in the FAL
is the driver. As that's the only instance that knows how to access the
file.

This patch makes sure the Indexer and FileExtensionFilter asks the
driver of the file extension instead of using the PathUtility itself.

Review

  • Code review CR +2
    • Markus Klein +2
    • Wouter Wolters +1
    • Frans Saris +1
  • Verified V +2
    • Markus Klein +2
    • TYPO3com +1 CI

Issues 1

Files 4

Review log 56

  1. Markus Klein uploaded patch set 1 04/16/18, 20:42

  2. Frans Saris voted on patch set 1 CR +1 04/16/18, 20:45

  3. TYPO3com voted on patch set 1 V +1 04/16/18, 20:52 Completed build in 09m 12s on Mon, 16 Apr, 10:52 PM Test Summary: 58269 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC87-2298

  4. Wouter Wolters voted on patch set 1 CR +1 04/16/18, 20:52

  5. Markus Klein voted on patch set 1 V +2 CR +2 04/16/18, 21:09

  6. Markus Klein merged patch set 2 04/16/18, 21:09