Review main Abandoned

56704[WIP][FEATURE] Add zoom functionality to view module

Dirk Jüttner CR 0 V 0 Hard +237 −53 updated 10/28/18, 10:39

Commit message

Select field for zooming in the view module.

Review

  • Code review CR 0
  • Verified V 0

Issues 1

Files 6

Review log 1321

  1. Dirk Jüttner uploaded patch set 1 04/17/18, 08:20

  2. TYPO3com voted on patch set 1 V +1 04/17/18, 08:33 Completed build in 12m 58s on Tue, 17 Apr, 10:33 AM Test Summary: 30950 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-22442

  3. Richard Haeser voted on patch set 1 V +1 CR +1 04/17/18, 08:53

  4. Dirk Jüttner uploaded patch set 2 04/17/18, 09:38

  5. Richard Haeser commented on patch set 2 04/17/18, 09:41

    Feature-84763-AddZoomFunctionalityToViewModule.rst:12

    Maybe more like: "You can now select the zoom-level in the View module"?
  6. TYPO3com voted on patch set 2 V +1 04/17/18, 09:47 Completed build in 09m 45s on Tue, 17 Apr, 11:47 AM Test Summary: 30950 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-22450

  7. Dirk Jüttner commented on patch set 3 04/17/18, 10:09

    Published edit on patch set 2.
  8. TYPO3com voted on patch set 3 V -1 04/17/18, 10:09 Completed build in 11s on Tue, 17 Apr, 12:09 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-22451

  9. TYPO3com voted on patch set 3 V +1 04/17/18, 13:05 Completed build in 12m 51s on Tue, 17 Apr, 03:05 PM Test Summary: 30950 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-22451

  10. Benjamin Kott commented on patch set 3 CR -1 04/17/18, 19:30

    the outer frame should always cover the preview, there should no white or black space on the left or the right after zooming. we propably need to decouple the orientation, device, zoom and dimensions from the preview container
  11. Benjamin Kott voted on patch set 3 V -1 04/17/18, 19:30

  12. Dirk Jüttner uploaded patch set 4 04/17/18, 20:44

  13. TYPO3com voted on patch set 4 V +1 04/17/18, 20:54 Completed build in 10m 18s on Tue, 17 Apr, 10:54 PM Test Summary: 30986 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-22506

  14. Mathias Schreiber commented on patch set 4 CR -1 04/17/18, 21:24

    Hi Dirk, just hit me up, I can explain the problems
  15. Dirk Jüttner uploaded patch set 5 04/18/18, 12:14

  16. TYPO3com voted on patch set 5 V +1 04/18/18, 12:23 Completed build in 09m 00s on Wed, 18 Apr, 02:23 PM Test Summary: 30986 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-22536

  17. Benjamin Kott uploaded patch set 6 04/19/18, 18:34

  18. TYPO3com voted on patch set 6 V +1 04/19/18, 18:47 Completed build in 12m 15s on Thu, 19 Apr, 08:47 PM Test Summary: 31052 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-22625

  19. Benjamin Kott uploaded patch set 7 04/20/18, 13:42

  20. TYPO3com voted on patch set 7 V +1 04/20/18, 13:52 Completed build in 10m 07s on Fri, 20 Apr, 03:52 PM Test Summary: 31052 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-22678

  21. Benni Mack abandoned the change 10/28/18, 10:39

    abandoned for now, as there was no feedback in the last 6 months. Can be restored later.