56706[BUGFIX] Bring back the maintenance information message
Commit message
Review
-
Code review CR +2
- Benni Mack +2
- Andreas Kienast +1
-
Verified V +2
- Benni Mack +2
- Andreas Kienast +1
- TYPO3com +1 CI
Issues 1
Files 4
Review log 2430
Show 45 earlier messages
-
Frank Nägler uploaded patch set 1 04/17/18, 10:09
-
Andreas Kienast commented on patch set 1 CR -1 04/17/18, 10:10
Resolves and Releases is missing -
Frank Nägler updated the commit message in patch set 2 04/17/18, 10:12
-
TYPO3com voted on patch set 2 V -1 04/17/18, 10:12 Completed build in 09s on Tue, 17 Apr, 12:12 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-22453
-
Andreas Kienast uploaded patch set 3 04/17/18, 10:13
-
TYPO3com voted on patch set 3 V -1 04/17/18, 10:28 Completed build in 14m 32s on Tue, 17 Apr, 12:28 PM Test Summary: 30144 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-22454
-
Markus Klein commented on patch set 3 04/17/18, 11:03
LockedBackendGuard.php:54hm... this is just a wild guess. -
TYPO3com voted on patch set 3 V +1 04/17/18, 11:40 Completed build in 1h 41m 15s on Tue, 17 Apr, 01:40 PM Test Summary: 30950 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-22454
-
Andreas Kienast voted on patch set 3 V +1 CR +1 04/17/18, 12:36
-
Markus Klein commented on patch set 3 CR -1 04/17/18, 13:39
see my comment. I suspect this may cause issues at some point -
Andreas Kienast commented on patch set 3 04/17/18, 13:41
> Patch Set 3: Code-Review-1 > > see my comment. > > I suspect this may cause issues at some point It's for consistency reasons as it gets validated in the JavaScript. Also, we're rewriting the LoginRefresh module right now. -
Frank Nägler commented on patch set 3 CR -2 04/17/18, 14:57
found another issue -
Andreas Kienast voted on patch set 3 V 0 CR -1 04/17/18, 14:58
-
Mathias Brodala commented on patch set 3 05/14/18, 14:38
What's the issue? -
Frank Nägler rebased onto patch set 4 05/16/18, 09:25
-
TYPO3com voted on patch set 4 V +1 05/16/18, 09:34 Completed build in 09m 20s on Wed, 16 May, 11:34 AM Test Summary: 31187 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-23525
-
Jörg Bösche voted on patch set 4 CR +1 06/06/18, 05:47
-
Frank Nägler commented on patch set 4 06/07/18, 13:10
@Mathias: The problem is, that the middleware runs not only for AJAX calls but also for normal requests in the backend, which results in a JSON string which is shown in the backend modules if you click anywhere -
Benni Mack uploaded patch set 5 07/03/18, 07:19
-
TYPO3com voted on patch set 5 V +1 07/03/18, 07:27 Completed build in 08m 22s on Tue, 3 Jul, 09:27 AM Test Summary: 32880 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-25056
-
Frank Nägler voted on patch set 5 CR 0 07/03/18, 07:48
-
Frank Nägler commented on patch set 5 CR -1 07/03/18, 08:00
on it -
Frank Nägler uploaded patch set 6 07/06/18, 19:08
-
Frank Nägler commented on patch set 6 CR -1 07/06/18, 19:09
-1 because I want a vote by Benni -
TYPO3com voted on patch set 6 V +1 07/06/18, 19:17 Completed build in 09m 28s on Fri, 6 Jul, 09:17 PM Test Summary: 32883 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-25191
-
Andreas Kienast commented on patch set 6 V +1 CR +1 07/06/18, 19:23
LockedBackendGuard.php:55Unresolved`$request->getHeaderLine('X-Requested-With') === 'XMLHttpRequest'` should also work -
Frank Nägler voted on patch set 6 CR -2 07/06/18, 20:05
-
Frank Nägler voted on patch set 6 CR 0 07/09/18, 09:30
-
Benni Mack voted on patch set 6 V +2 CR +2 07/09/18, 09:31
-
Benni Mack merged patch set 7 07/09/18, 09:31