Review main Merged

56706[BUGFIX] Bring back the maintenance information message

Frank Nägler CR +2 V +2 Normal +63 −27 updated 07/09/18, 09:31

Commit message

In case the adminOnly flag is set, an information window is shown.
The middleware now creates a valid JSON response to show
the information window again.

Review

  • Code review CR +2
    • Benni Mack +2
    • Andreas Kienast +1
  • Verified V +2
    • Benni Mack +2
    • Andreas Kienast +1
    • TYPO3com +1 CI

Issues 1

Files 4

Review log 2430

Show 45 earlier messages
  1. Frank Nägler uploaded patch set 1 04/17/18, 10:09

  2. Andreas Kienast commented on patch set 1 CR -1 04/17/18, 10:10

    Resolves and Releases is missing
  3. Frank Nägler updated the commit message in patch set 2 04/17/18, 10:12

  4. TYPO3com voted on patch set 2 V -1 04/17/18, 10:12 Completed build in 09s on Tue, 17 Apr, 12:12 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-22453

  5. Andreas Kienast uploaded patch set 3 04/17/18, 10:13

  1. TYPO3com voted on patch set 3 V -1 04/17/18, 10:28 Completed build in 14m 32s on Tue, 17 Apr, 12:28 PM Test Summary: 30144 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-22454

  2. Markus Klein commented on patch set 3 04/17/18, 11:03

    LockedBackendGuard.php:54

    hm... this is just a wild guess.
  3. TYPO3com voted on patch set 3 V +1 04/17/18, 11:40 Completed build in 1h 41m 15s on Tue, 17 Apr, 01:40 PM Test Summary: 30950 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-22454

  4. Andreas Kienast voted on patch set 3 V +1 CR +1 04/17/18, 12:36

  5. Markus Klein commented on patch set 3 CR -1 04/17/18, 13:39

    see my comment. I suspect this may cause issues at some point
  6. Andreas Kienast commented on patch set 3 04/17/18, 13:41

    > Patch Set 3: Code-Review-1 > > see my comment. > > I suspect this may cause issues at some point It's for consistency reasons as it gets validated in the JavaScript. Also, we're rewriting the LoginRefresh module right now.
  7. Frank Nägler commented on patch set 3 CR -2 04/17/18, 14:57

    found another issue
  8. Andreas Kienast voted on patch set 3 V 0 CR -1 04/17/18, 14:58

  9. Mathias Brodala commented on patch set 3 05/14/18, 14:38

    What's the issue?
  10. Frank Nägler rebased onto patch set 4 05/16/18, 09:25

  11. TYPO3com voted on patch set 4 V +1 05/16/18, 09:34 Completed build in 09m 20s on Wed, 16 May, 11:34 AM Test Summary: 31187 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-23525

  12. Jörg Bösche voted on patch set 4 CR +1 06/06/18, 05:47

  13. Frank Nägler commented on patch set 4 06/07/18, 13:10

    @Mathias: The problem is, that the middleware runs not only for AJAX calls but also for normal requests in the backend, which results in a JSON string which is shown in the backend modules if you click anywhere
  14. Benni Mack uploaded patch set 5 07/03/18, 07:19

  15. TYPO3com voted on patch set 5 V +1 07/03/18, 07:27 Completed build in 08m 22s on Tue, 3 Jul, 09:27 AM Test Summary: 32880 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-25056

  16. Frank Nägler voted on patch set 5 CR 0 07/03/18, 07:48

  17. Frank Nägler commented on patch set 5 CR -1 07/03/18, 08:00

    on it
  18. Frank Nägler uploaded patch set 6 07/06/18, 19:08

  19. Frank Nägler commented on patch set 6 CR -1 07/06/18, 19:09

    -1 because I want a vote by Benni
  20. TYPO3com voted on patch set 6 V +1 07/06/18, 19:17 Completed build in 09m 28s on Fri, 6 Jul, 09:17 PM Test Summary: 32883 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-25191

  21. Andreas Kienast commented on patch set 6 V +1 CR +1 07/06/18, 19:23

    LockedBackendGuard.php:55 Unresolved

    `$request->getHeaderLine('X-Requested-With') === 'XMLHttpRequest'` should also work
  22. Frank Nägler voted on patch set 6 CR -2 07/06/18, 20:05

  23. Frank Nägler voted on patch set 6 CR 0 07/09/18, 09:30

  24. Benni Mack voted on patch set 6 V +2 CR +2 07/09/18, 09:31

  25. Benni Mack merged patch set 7 07/09/18, 09:31