56709[BUGFIX] Handle missing repository mirrors in Languages module
Commit message
Review
-
Code review CR +2
- Christian Kuhn +2
- Riny van Tiggelen +1
-
Verified V +2
- Christian Kuhn +2
- Stefan Neufeind +1
- TYPO3com +1 CI
Issues 1
Files 1
Review log 1012
-
Mathias Brodala uploaded patch set 1 04/17/18, 12:58
-
TYPO3com voted on patch set 1 V -1 04/17/18, 13:14 Completed build in 15m 40s on Tue, 17 Apr, 03:14 PM Test Summary: 58269 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC87-2305
-
Mathias Brodala commented on patch set 2 04/17/18, 13:21
Published edit on patch set 1. -
Mathias Brodala commented on patch set 2 04/17/18, 13:22
Use unique exception code. -
TYPO3com voted on patch set 2 V +1 04/17/18, 13:31 Completed build in 09m 22s on Tue, 17 Apr, 03:31 PM Test Summary: 58269 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC87-2306
-
Stefan Neufeind commented on patch set 2 V -1 06/22/18, 21:01
The hard fail (exception) is gone. But I don't see a hint about the exception that happened. Shouldn't we show/log one? -
Mathias Brodala commented on patch set 2 06/23/18, 10:25
> The hard fail (exception) is gone. But I don't see a hint about the > exception that happened. Shouldn't we show/log one? Technically it is actually fine to have no repository entry in the database since one could also be set by the "postProcessMirrorUrl" signal in the TranslationService. If there is no mirror URL in the end, loading translations will fail with a proper error flash message. (Although the exact error is not shown there ATM.) -
Stefan Neufeind commented on patch set 2 V +1 06/23/18, 10:27
showing that error is what I meant/expected. Can you add some error-display here or as a separate patch? Separate would be fine since here you fix the error itself. -
Mathias Brodala commented on patch set 2 06/23/18, 10:31
> showing that error is what I meant/expected. Can you add some > error-display here or as a separate patch? Separate would be fine > since here you fix the error itself. This requires a few changes in the LanguageModule script but should be doable, yeah, -
Riny van Tiggelen voted on patch set 2 CR +1 07/02/18, 09:48
-
Christian Kuhn voted on patch set 2 V +2 CR +2 07/02/18, 11:50
-
Christian Kuhn merged patch set 3 07/02/18, 11:50