56710[FEATURE] Create new renderType for domain records
Commit message
Review
-
Code review CR 0
-
Verified V 0
Issues 1
Files 11
- Build/Resources/Public/Sass/typo3/_main_form.scss+7 −0
- typo3/sysext/backend/Classes/Form/Element/InputDomainElement.php4new+257 −0
- typo3/sysext/backend/Classes/Form/NodeFactory.php+1 −0
- typo3/sysext/backend/Resources/Private/TypeScript/SchemeSelect.tsnew+49 −0
- typo3/sysext/backend/Resources/Public/Css/backend.css+1 −1
- typo3/sysext/backend/Resources/Public/JavaScript/FormEngineValidation.js+9 −0
- typo3/sysext/backend/Resources/Public/JavaScript/SchemeSelect.jsnew+13 −0
- typo3/sysext/core/Classes/DataHandling/DataHandler.php1+30 −0
- typo3/sysext/core/Documentation/Changelog/master/Feature-84767-SupplyRenderTypeForDomains.rst2new+47 −0
- typo3/sysext/install/Resources/Public/Css/install.css+1 −1
- typo3/sysext/lang/Resources/Private/Language/locallang_core.xlf+3 −0
Review log 1418
-
Marc Wessels uploaded patch set 1 04/17/18, 14:06
-
TYPO3com voted on patch set 1 V -1 04/17/18, 14:06 Completed build in 12s on Tue, 17 Apr, 04:06 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-22472
-
Georg Ringer commented on patch set 1 04/17/18, 14:18
that is of course a FEATURE and requires a RST file which can be created best at https://forger.typo3.com/utility/rst -
Andreas Kienast uploaded patch set 2 04/17/18, 14:20
-
Andreas Kienast commented on patch set 2 CR -1 04/17/18, 14:22
Will add the ReST file with Marc -
Andreas Kienast uploaded patch set 3 04/17/18, 14:30
-
TYPO3com voted on patch set 2 V +1 04/17/18, 14:31 Completed build in 11m 05s on Tue, 17 Apr, 04:31 PM Test Summary: 30950 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-22473
-
Richard Haeser commented on patch set 3 04/17/18, 14:33
Is it good to have the base field in the SiteConfigurationTca to have this renderType? -
Richard Haeser commented on patch set 3 04/17/18, 14:37
InputDomainElement.php:152I think https should be the first value, because you only should use other schemes if you know what you are doing. -
TYPO3com voted on patch set 3 V +1 04/17/18, 14:40 Completed build in 10m 14s on Tue, 17 Apr, 04:40 PM Test Summary: 30950 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-22476
-
Mathias Schreiber commented on patch set 3 V -1 04/17/18, 19:38
waiting for IP addresses to validate properly -
Marc Wessels uploaded patch set 4 04/17/18, 19:54
-
TYPO3com voted on patch set 4 V +1 04/17/18, 20:07 Completed build in 13m 09s on Tue, 17 Apr, 10:07 PM Test Summary: 30986 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-22495
-
Mathias Schreiber voted on patch set 4 V +1 CR +1 04/17/18, 20:11
-
Nicole Hummel commented on patch set 4 04/25/18, 10:23
InputDomainElement.php:26IMHO not true, needs some proper descriptionInputDomainElement.php:150This needs proper "selected" handling, doesn't it?InputDomainElement.php:188Do we really need to support a checkbox before this render type?DataHandler.php:2996Is there any reason why we don't use parse_url (http://php.net/manual/en/function.parse-url.php) here?Feature-84767-SupplyRenderTypeForDomains.rst:19I would love to see those new functions to be splited into separate patches. One that introduces a new renderType (maybe even with select-field configuration to work independent from domains) and one that introduces a new eval functionFeature-84767-SupplyRenderTypeForDomains.rst:32Which one is selected then? -
Georg Ringer commented on patch set 4 04/27/18, 07:34
dont use the wording "domain records" ... IMO this are just domains... "domain records" === sys_domain (IMO) -
Benni Mack commented on patch set 4 08/31/18, 12:58
how about a "renderType" URI? -
Benni Mack abandoned the change 10/28/18, 12:16
no activity for 6 months, even after my comment 8 weeks ago, I'll abandon this for now, can be restored later.