Review main Merged

56731[BUGFIX] Check if file exists for backend logo

Lidia Demin CR +2 V +2 Easy +1 −1 updated 04/19/18, 20:57

Commit message

If an invalid file path is given, an exception is thrown if trying to
access its properties and the backend is not accessible any more.
Check if file exists before accessing. If not use default.

Review

  • Code review CR +2
    • Andreas Kienast +2
    • Mathias Schreiber +1
    • Oliver Klee +1
    • Kay Strobach +1
  • Verified V +2
    • Andreas Kienast +2
    • Mathias Schreiber +1
    • Kay Strobach +1
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 89

  1. Lidia Demin uploaded patch set 1 04/19/18, 08:32

  2. TYPO3com voted on patch set 1 V +1 04/19/18, 08:42 Completed build in 10m 32s on Thu, 19 Apr, 10:42 AM Test Summary: 31004 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-22571

  3. Oliver Klee voted on patch set 1 CR +1 04/19/18, 09:02

  4. Andreas Kienast voted on patch set 1 CR +1 04/19/18, 09:13

  5. Kay Strobach voted on patch set 1 V +1 CR +1 04/19/18, 17:41

  6. Mathias Schreiber voted on patch set 1 V +1 CR +1 04/19/18, 18:06

  7. Andreas Kienast voted on patch set 1 V +2 CR +2 04/19/18, 20:57

  8. Andreas Kienast merged patch set 2 04/19/18, 20:57

  9. Andreas Kienast commented on patch set 2 04/19/18, 20:57

    Cherry Picked This patchset was cherry picked to branch TYPO3_8-7 as commit 99c79c437e006044e0b9f2b3fb0248cda44692a9