Review main Merged

56732[FEATURE] Add scheduler task to anonymize IP addresses of tables

Georg Ringer CR +2 V +2 Hard +490 −0 updated 11/27/19, 08:53

Commit message

IP anonymizing improves the privacy of users and required as part of
the GDPR.

Review

  • Code review CR +2
    • Andreas Wolf +2
    • Mathias Schreiber +1
  • Verified V +2
    • Andreas Wolf +2
    • Mathias Schreiber +1
    • TYPO3com +1 CI

Issues 1

Files 6

Review log 2735

Show 510 earlier messages
  1. Georg Ringer uploaded patch set 1 04/19/18, 11:38

  2. TYPO3com voted on patch set 1 V -1 04/19/18, 11:48 Completed build in 10m 37s on Thu, 19 Apr, 01:48 PM Test Summary: 31022 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-22581

  3. Georg Ringer uploaded patch set 2 04/23/18, 18:27

  4. TYPO3com voted on patch set 2 V -1 04/23/18, 18:27 Completed build in 10s on Mon, 23 Apr, 08:27 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-22840

  5. Georg Ringer uploaded patch set 3 04/23/18, 18:30

  6. TYPO3com voted on patch set 3 V -1 04/23/18, 18:40 Completed build in 09m 47s on Mon, 23 Apr, 08:40 PM Test Summary: 31052 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-22841

  7. Georg Ringer uploaded patch set 4 04/23/18, 23:32

  8. TYPO3com voted on patch set 4 V +1 04/23/18, 23:42 Completed build in 10m 06s on Tue, 24 Apr, 01:42 AM Test Summary: 31052 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-22847

  9. Markus Klein commented on patch set 5 04/24/18, 08:19

    Published edit on patch set 4.
  10. TYPO3com voted on patch set 5 V +1 04/24/18, 08:28 Completed build in 08m 31s on Tue, 24 Apr, 10:28 AM Test Summary: 31052 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-22851

  1. Simon Gilli commented on patch set 5 CR -1 04/24/18, 08:28

    Scheduler.php:450 Unresolved

    please explain this early return

    IpAnonymizationAdditionalFieldProvider.php:182

    mask is missing

    IpAnonymizationAdditionalFieldProvider.php:235 Unresolved

    mask is missing

    IpAnonymizationTask.php:61

    wouldn't it be better if you use the return of handleTable and in minimum one (or all) call has to be true?

    ext_localconf.php:97 Unresolved

    description is from garbage collection task

    ext_localconf.php:102 Unresolved

    here too
  2. Guido Schmechel commented on patch set 5 04/24/18, 11:16

    IpAnonymizationAdditionalFieldProvider.php:120 Unresolved

    $fieldId to top for another literals

    IpAnonymizationAdditionalFieldProvider.php:152 Unresolved

    You could move this $fieldId to top and use it instead of literals

    IpAnonymizationTask.php:110

    Do we set default parameters? (\PDO::PARAM_STR)
  3. Georg Ringer commented on patch set 5 04/24/18, 12:58

    IpAnonymizationAdditionalFieldProvider.php:182 Reply Unresolved

    there is IMO no need to valid it, good default set anyway

    IpAnonymizationTask.php:61 Reply Unresolved

    i copied it from garbagecollectiontask. IMO it is fine like that

    IpAnonymizationTask.php:110 Reply Unresolved

    until now we did
  4. Georg Ringer uploaded patch set 6 04/24/18, 12:58

  5. TYPO3com voted on patch set 6 V +1 04/24/18, 13:08 Completed build in 09m 40s on Tue, 24 Apr, 03:08 PM Test Summary: 31052 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-22853

  6. Tymoteusz Motylewski voted on patch set 6 CR +1 04/24/18, 13:34

  7. Simon Gilli voted on patch set 6 CR +1 04/24/18, 14:20

  8. Wouter Wolters commented on patch set 6 04/24/18, 14:23

    IpAnonymizationAdditionalFieldProvider.php:81

    $disabled is always an empty string here

    IpAnonymizationTask.php:146

    return directly?
  9. Georg Ringer uploaded patch set 7 05/02/18, 17:26

  10. TYPO3com voted on patch set 7 V +1 05/02/18, 17:34 Completed build in 08m 24s on Wed, 2 May, 07:34 PM Test Summary: 31061 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-23013

  11. Wouter Wolters voted on patch set 7 CR +1 05/02/18, 18:30

  12. Markus Klein voted on patch set 7 CR +1 05/02/18, 22:26

  13. Andreas Wolf uploaded patch set 8 05/04/18, 12:14

  14. Andreas Wolf voted on patch set 8 V +1 CR +1 05/04/18, 12:17

  15. Andreas Wolf commented on patch set 8 05/04/18, 12:19

    Fixed one issue where configuring the number of days did not work (because the field ID did not match between the field provider and the task).
  16. Mathias Schreiber voted on patch set 8 V +1 CR +1 05/04/18, 12:23

  17. TYPO3com voted on patch set 8 V +1 05/04/18, 12:24 Completed build in 09m 21s on Fri, 4 May, 02:24 PM Test Summary: 31064 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-23043

  18. Andreas Wolf voted on patch set 8 V +2 CR +2 05/04/18, 12:37

  19. Andreas Wolf merged patch set 9 05/04/18, 12:37

  20. Stephan Großberndt commented on patch set 9 05/09/18, 15:10

    Backports to 8.7 and 7.6 are missing
  21. Jigal van Hemert commented on patch set 9 05/11/18, 12:56

    Cherry Picked This patchset was cherry picked to branch TYPO3_8-7 as commit 1422415c2b908a1dee01274e6bae9dc8bfd65940
  22. Oliver Hader commented on patch set 9 05/12/18, 12:59

    IpAnonymizationTask.php:58

    isset($GLOBALS['TYPO3_CONF_VARS']['SC_OPTIONS']['scheduler']['tasks'][self::class]['options']['tables'][$this->table])?!
  23. Markus Klein commented on patch set 9 05/12/18, 17:52

    IpAnonymizationTask.php:58 Reply

    lol... you're so right.
  24. Markus Klein commented on patch set 9 05/12/18, 18:02

  25. Oliver Hader commented on patch set 9 05/22/18, 08:54

    Cherry Picked This patchset was cherry picked to branch 9.2 as commit 1f052b273ccaa1400d720a248f1480f2611dce54