Review main Abandoned

56735[TASK] Move linkbrowser popup to modal

Philipp Hamid CR 0 V 0 Expert +756 −616 updated 10/28/18, 13:49

Commit message

The linkbrowser opens now in a modal like ckeditor.

Review

  • Code review CR 0
  • Verified V 0

Issues 1

Files 13

Review log 3045

Show 1020 earlier messages
  1. Philipp Hamid uploaded patch set 1 04/19/18, 12:06

  2. TYPO3com voted on patch set 1 V -1 04/19/18, 12:18 Completed build in 11m 26s on Thu, 19 Apr, 02:18 PM Test Summary: 19 of 31174 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-22587

  3. Philipp Hamid updated the commit message in patch set 2 04/20/18, 19:02

  4. TYPO3com voted on patch set 2 V -1 04/20/18, 19:14 Completed build in 12m 04s on Fri, 20 Apr, 09:14 PM Test Summary: 19 of 31204 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-22716

  5. TYPO3com commented on patch set 2 04/20/18, 19:59 Completed build in 1h 09m 34s on Fri, 20 Apr, 09:59 PM Test Summary: 19 of 31204 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-22716

  6. TYPO3com commented on patch set 2 04/20/18, 20:09 Completed build in 2h 17m 21s on Fri, 20 Apr, 10:09 PM Test Summary: 20 of 31204 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-22716

  7. Frank Nägler uploaded patch set 3 04/20/18, 20:22

  8. Frank Nägler commented on patch set 3 CR -1 04/20/18, 20:24

    currently this patch build a hard dependency to rte_ckeditor. this is the reason why the acceptance tests fails. the route is defined in EXT:rte_ckeditor but is used outside the extension scope.
  9. TYPO3com voted on patch set 3 V -1 04/20/18, 20:30 Completed build in 08m 30s on Fri, 20 Apr, 10:30 PM Test Summary: 19 of 31204 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-22734

  10. Philipp Hamid uploaded patch set 4 04/21/18, 09:42

  11. TYPO3com voted on patch set 4 V -1 04/21/18, 09:42 Completed build in 10s on Sat, 21 Apr, 11:42 AM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-22765

  12. Philipp Hamid uploaded patch set 5 04/21/18, 10:04

  13. TYPO3com voted on patch set 5 V +1 04/21/18, 10:14 Completed build in 09m 58s on Sat, 21 Apr, 12:14 PM Test Summary: 31052 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-22767

  14. Frank Nägler uploaded patch set 6 04/21/18, 10:36

  15. TYPO3com voted on patch set 6 V -1 04/21/18, 10:36 Completed build in 10s on Sat, 21 Apr, 12:36 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-22772

  16. Philipp Hamid uploaded patch set 7 04/21/18, 18:14

  17. TYPO3com voted on patch set 7 V -1 04/21/18, 18:14 Completed build in 11s on Sat, 21 Apr, 08:14 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-22815

  18. Philipp Hamid rebased onto patch set 8 04/21/18, 18:18

  19. TYPO3com commented on patch set 8 04/21/18, 18:18 Completed build in 10s on Sat, 21 Apr, 08:18 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-22816

  20. Philipp Hamid uploaded patch set 9 04/21/18, 18:19

  1. TYPO3com voted on patch set 9 V +1 04/21/18, 18:28 Completed build in 09m 39s on Sat, 21 Apr, 08:28 PM Test Summary: 31052 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-22817

  2. Frank Nägler commented on patch set 9 CR -1 04/23/18, 08:01

    LinkPopup.php:62

    removing this fields could be a breaking change, the fieldChangeFunc e.g. is function which can't be called if it is removed here. I guess this needs more love and investigation.
  3. Frank Nägler uploaded patch set 10 04/25/18, 09:06

  4. Frank Nägler commented on patch set 10 CR -2 04/25/18, 09:13

    on it
  5. TYPO3com voted on patch set 10 V +1 04/25/18, 09:17 Completed build in 10m 44s on Wed, 25 Apr, 11:17 AM Test Summary: 31061 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-22889

  6. Frank Nägler uploaded patch set 11 04/25/18, 13:18

  7. TYPO3com voted on patch set 11 V +1 04/25/18, 13:29 Completed build in 10m 27s on Wed, 25 Apr, 03:29 PM Test Summary: 31061 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-22896

  8. Andreas Kienast commented on patch set 11 04/25/18, 13:31

    LinkPopup.php:67

    Would $GLOBALS['BE_USER']->uc['lang'] work here?
  9. Wouter Wolters commented on patch set 11 04/25/18, 13:47

    LinkPopup.php:37

    should be core
  10. Sybille Peters commented on patch set 11 05/14/18, 20:46

    Routes.php:66

    Could you add a commit that will make it clear what is the difference between wizard_link and wizard_browser_links here?

    Deprecation-84769-ChangeHeaderLinkPopupToModal.rst:20 Unresolved

    It might be helpful to add a little more context so that people not familiar with this patch will know from reading the Changelog what has changed without having to read all changes in this patch. For example: instead of "or the old route" write which route (so they don't have to look it up themselves). "Having the functionality of BrowseLinksController also for common links in the backend" - what does that mean? What has changed in the functionality? What can be done that couldn't be done before?
  11. Sybille Peters commented on patch set 11 05/14/18, 20:51

    Routes.php:66 Reply Unresolved

    sorry, I meant "Could you add a comment". (not commit)
  12. Frank Nägler commented on patch set 11 08/10/18, 17:45

    LinkPopup.php:37 Reply

    good point, thx!

    LinkPopup.php:67 Reply Unresolved

    not sure
  13. Frank Nägler uploaded patch set 12 08/10/18, 17:49

  14. Frank Nägler voted on patch set 12 CR 0 08/10/18, 17:50

  15. TYPO3com voted on patch set 12 V +1 08/10/18, 17:56 Completed build in 06m 07s on Fri, 10 Aug, 07:56 PM Test Summary: 33679 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-26373

  16. Jörg Bösche commented on patch set 12 CR -1 08/13/18, 12:02

    I'm missing the "rel" attribute field in the implementation. It existed in the previous linkbrowser popup.

    LinkPopup.php:81

    What is about the "rel" field? It is defined in getLinkAttributeFieldDefinitions::getLinkAttributeFieldDefinitions().

    FormEngine.js:1118

    "rel" field is missing

    FormEngine.js:1139

    "rel" field is missing

    typo3link.js:156

    "rel" field?
  17. Jörg Bösche uploaded patch set 13 08/16/18, 14:16

  18. TYPO3com voted on patch set 13 V +1 08/16/18, 14:24 Completed build in 07m 37s on Thu, 16 Aug, 04:24 PM Test Summary: 34863 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-26667

  19. Frank Nägler voted on patch set 13 V +1 CR +1 08/17/18, 18:36

  20. Christian Kuhn commented on patch set 13 08/19/18, 09:01

    +1 on testing. however, i'm not fully satisfied with some code details, especially the .rst file reads bumpy. i'll try to come up with something.
  21. Christian Kuhn commented on patch set 13 CR -1 08/19/18, 09:23

    i actually dislike the dependency from backend to ckeditor, even if it is a weak dependency. we should somehow find some different solution.

    BrowseLinksController.php:148

    this shows a structural problem of the patch: my merging the ckeditor controller into ext:backend we create a loose, but hard coded cross dependency from backend to ckeditor. we should avoid such things. maybe we should keep the ckeeditor route and controller and let it extend the class again? this is upgly too, but at least the cross dependency would be gone.

    Deprecation-84769-ChangeHeaderLinkPopupToModal.rst:12

    that section sounds bumpy.

    BrowseLinksController.php:30

    double trigger_error?
  22. Markus Klein commented on patch set 13 CR -1 08/19/18, 09:31

    BrowseLinks implementation, which is specific to an editor MUST NOT be part of the backend extension. I spent a lot of time some years ago to decouple that stuff
  23. Frank Nägler commented on patch set 13 08/20/18, 07:20

    Fine with all comments and remarks, but has anyone a constructive feedback how to solve the issue? Means open the linkbrowser in modal and not in a popup? If so, feel free to update the patch and fix it. I have not the time to work again on the patch, any help here is welcome. agains the dependency remarks I disagree, but also fine with any other solution which fix the issue.
  24. Markus Klein commented on patch set 13 08/20/18, 07:21

    I can take a look at it, but not before feature freeze.
  25. Benni Mack abandoned the change 10/28/18, 13:49

    As Frank stated - as soon as someone has a feasable solution we can continue on this.