Review main Merged

56736[TASK] Add new language labels

Ingo Nolden CR +2 V +2 Easy +9 −0 updated 04/25/18, 14:33

Commit message

New labels for the new checkbox rendertypes.
The visibility checkbox in most record types uses the same language
label. The new rendertype checkboxToggle for the visibility checkbox
needs a new label to avoid breaking changes to checkboxes that don´t
get the new rendertype.

Review

  • Code review CR +2
    • Andreas Kienast +2
    • Mathias Schreiber +1
    • Jo Hasenau +1
    • Oliver Klee +1
    • Kay Strobach +1
    • Dirk Jüttner +1
    • Susi Moog +1
  • Verified V +2
    • Andreas Kienast +2
    • Mathias Schreiber +1
    • Jo Hasenau +1
    • Kay Strobach +1
    • TYPO3com +1 CI

Issues 2

Files 1

Review log 1822

  1. Ingo Nolden uploaded patch set 1 04/19/18, 13:13

  2. Björn Jacob voted on patch set 1 CR +1 04/19/18, 13:15

  3. TYPO3com voted on patch set 1 V -1 04/19/18, 13:24 Completed build in 10m 55s on Thu, 19 Apr, 03:24 PM Test Summary: 1 of 31174 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-22595

  4. Björn Jacob voted on patch set 1 CR 0 04/19/18, 13:42

  5. Ingo Nolden updated the commit message in patch set 2 04/19/18, 13:52

  6. TYPO3com voted on patch set 2 V +1 04/19/18, 14:05 Completed build in 12m 02s on Thu, 19 Apr, 04:05 PM Test Summary: 31022 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-22603

  7. Kay Strobach voted on patch set 2 V +1 CR +1 04/19/18, 17:38

  8. Mathias Schreiber commented on patch set 2 V -1 04/19/18, 18:08

    these need to go into EXT:core. We're dropping EXT:lang soon. Furthermore the commit message could use a little more information :)
  9. Ingo Nolden updated the commit message in patch set 3 04/19/18, 20:34

  10. TYPO3com voted on patch set 3 V +1 04/19/18, 20:43 Completed build in 08m 58s on Thu, 19 Apr, 10:43 PM Test Summary: 31052 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-22631

  11. Ingo Nolden commented on patch set 3 04/19/18, 20:46

    The core currently doesn´t have a language file for general labels. Does it make sense to start a new file with 2 labels if according to https://review.typo3.org/#/c/56017/ all language files from lang will be completely moved to core? Then we would have general labels separated in 2 files.
  12. Ingo Nolden commented on patch set 4 04/20/18, 15:16

    Published edit on patch set 3.
  13. TYPO3com voted on patch set 4 V +1 04/20/18, 15:25 Completed build in 08m 51s on Fri, 20 Apr, 05:25 PM Test Summary: 31052 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-22692

  14. Susi Moog voted on patch set 4 CR +1 04/20/18, 19:38

  15. Dirk Jüttner commented on patch set 4 CR +1 04/20/18, 19:50

    Labels not in use at the moment but syntax is okay.
  16. Mathias Schreiber voted on patch set 4 V +1 CR +1 04/21/18, 07:30

  17. Oliver Klee voted on patch set 4 CR +1 04/21/18, 07:45

  18. Kay Strobach voted on patch set 4 V +1 CR +1 04/21/18, 08:26

  19. Jo Hasenau voted on patch set 4 V +1 CR +1 04/21/18, 12:28

  20. Andreas Kienast voted on patch set 4 V +2 CR +2 04/21/18, 12:43

  21. Andreas Kienast merged patch set 5 04/21/18, 12:43

  22. Alexander Opitz commented on patch set 5 04/25/18, 14:33

    Post -1 in Code Review. The commit message is wrong, please use the plural form of "Release". So correct would be in this case. Releases: master