Review main Merged

56741[TASK] Change checkboxes in be_groups and be_users to new rendertype

Ingo Nolden CR +2 V +2 Normal +62 −11 updated 04/30/18, 08:42

Commit message

Some checkboxes are changed to new rendertype checkboxToggle.
One checkbox label (IPlockState) is added.

Review

  • Code review CR +2
    • Benjamin Kott +2
    • Frank Nägler +1
  • Verified V +2
    • Benjamin Kott +2
    • Frank Nägler +1
    • TYPO3com +1 CI

Issues 2

Files 3

Review log 2231

Show 36 earlier messages
  1. Ingo Nolden uploaded patch set 1 04/19/18, 16:23

  2. TYPO3com voted on patch set 1 V +1 04/19/18, 16:32 Completed build in 08m 46s on Thu, 19 Apr, 06:32 PM Test Summary: 31022 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-22615

  3. Ingo Nolden commented on patch set 2 04/19/18, 20:57

    Published edit on patch set 1.
  4. TYPO3com voted on patch set 2 V +1 04/19/18, 21:09 Completed build in 11m 40s on Thu, 19 Apr, 11:09 PM Test Summary: 31052 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-22638

  5. Ingo Nolden commented on patch set 3 04/20/18, 15:20

    Published edit on patch set 2.
  6. TYPO3com voted on patch set 3 V +1 04/20/18, 15:29 Completed build in 08m 42s on Fri, 20 Apr, 05:29 PM Test Summary: 31052 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-22693

  1. Ingo Nolden commented on patch set 4 04/20/18, 19:00

    Published edit on patch set 3.
  2. TYPO3com voted on patch set 4 V +1 04/20/18, 19:12 Completed build in 12m 13s on Fri, 20 Apr, 09:12 PM Test Summary: 31052 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-22715

  3. Dirk Jüttner commented on patch set 1 04/21/18, 10:02

    be_groups.php:126

    'default' => 0 is missing
  4. Dirk Jüttner commented on patch set 4 CR -1 04/21/18, 10:22

    'default' => 0 is missing

    be_groups.php:117

    'default' => 0 is missing

    be_groups.php:126 Reply

    Done

    be_groups.php:199

    'default' => 0 is missing

    be_groups.php:201

    'default' => 0 is missing
  5. Jo Hasenau updated the commit message in patch set 5 04/21/18, 12:37

  6. TYPO3com voted on patch set 5 V +1 04/21/18, 12:58 Completed build in 21m 18s on Sat, 21 Apr, 02:58 PM Test Summary: 31052 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-22790

  7. Ingo Nolden uploaded patch set 6 04/21/18, 13:14

  8. TYPO3com voted on patch set 6 V +1 04/21/18, 13:22 Completed build in 08m 22s on Sat, 21 Apr, 03:22 PM Test Summary: 31052 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-22798

  9. Dirk Jüttner commented on patch set 6 V -1 04/21/18, 16:35

    be_groups.php:118

    syntax error, unexpected '<<' (T_SL), expecting ']' ParseError thrown in file /Users/JPDesign/daten/webspace/t3uxw18/typo3/sysext/core/Configuration/TCA/be_groups.php in line 118.
  10. Dirk Jüttner voted on patch set 6 V +1 CR +1 04/21/18, 17:55

  11. Oliver Hader wrote 04/21/18, 18:41

    Topic set to ux-checkboxes
  12. Alexander Opitz uploaded patch set 7 04/25/18, 14:17

  13. Alexander Opitz commented on patch set 7 04/25/18, 14:19

    Resolved merge conflict and fixed indentation. I'm nor sure if the adding of "'exclude' => 1" does have todo with this patch.
  14. TYPO3com voted on patch set 7 V +1 04/25/18, 14:28 Completed build in 10m 38s on Wed, 25 Apr, 04:28 PM Test Summary: 31061 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-22899

  15. Frank Nägler voted on patch set 7 V +1 CR +1 04/27/18, 09:05

  16. Frank Nägler commented on patch set 7 CR -1 04/27/18, 09:16

    check it again
  17. Frank Nägler uploaded patch set 8 04/27/18, 09:19

  18. Frank Nägler voted on patch set 8 V +1 CR +1 04/27/18, 09:20

  19. Frank Nägler uploaded patch set 9 04/27/18, 09:24

  20. Frank Nägler voted on patch set 9 V +1 CR +1 04/27/18, 09:27

  21. TYPO3com voted on patch set 8 V -1 04/27/18, 09:31 Completed build in 11m 45s on Fri, 27 Apr, 11:31 AM Test Summary: 1 of 31213 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-22963

  22. TYPO3com voted on patch set 9 V +1 04/27/18, 09:33 Completed build in 09m 31s on Fri, 27 Apr, 11:33 AM Test Summary: 31061 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-22964

  23. Benjamin Kott voted on patch set 9 V +2 CR +2 04/27/18, 09:34

  24. Benjamin Kott merged patch set 10 04/27/18, 09:34

  25. Alexander Opitz commented on patch set 10 04/30/18, 08:42

    Adding the exclude fields do not have todo with this task, if they are needed, they should have to go inside another patch and may also need documentation.