Review TYPO3_8-7 Merged

56744[BUGFIX] Do not write empty array values in form definitions

Oliver Hader CR +2 V +2 Normal +65 −4 updated 04/19/18, 18:37

Commit message

Symfony YAML dumps empty arrays as sequence ("{  }"). Due to this, some
JavaScript modules of the form framework fail to interpret/ set the
correct data type for those properties.

If applied, this commit will ensure that the formEditor unsets empty
array keys on load/ save.

The problem only affects the backend module, not the frontend
formDefinition interpreter.

Review

  • Code review CR +2
    • Oliver Hader +2
  • Verified V +2
    • Oliver Hader +2
    • TYPO3com +1 CI

Issues 1

Files 3

Review log 46

  1. Oliver Hader uploaded patch set 1 04/19/18, 18:13

  2. Ralf Zimmermann uploaded patch set 2 04/19/18, 18:26

  3. TYPO3com voted on patch set 1 V +1 04/19/18, 18:27 Completed build in 14m 05s on Thu, 19 Apr, 08:27 PM Test Summary: 58383 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC87-2331

  4. Oliver Hader voted on patch set 2 V +2 CR +2 04/19/18, 18:35

  5. TYPO3com voted on patch set 2 V +1 04/19/18, 18:36 Completed build in 09m 23s on Thu, 19 Apr, 08:36 PM Test Summary: 58383 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC87-2332

  6. Oliver Hader merged patch set 3 04/19/18, 18:37