56745[BUGFIX] Make labeledToggleCheckbox localizable
Commit message
Review
-
Code review CR +2
- Markus Klein +2
- Jan Delius +1
- Jan Stockfisch +1
- Richard Haeser +1
- Riny van Tiggelen +1
- Andreas Kienast +1
- Michael Oehlhof +1
-
Verified V +2
- Markus Klein +2
- Jan Delius +1
- Richard Haeser +1
- Andreas Kienast +1
- TYPO3com +1 CI
Issues 1
Files 1
Review log 1518
-
Mathias Schreiber uploaded patch set 1 04/19/18, 18:54
-
Markus Klein commented on patch set 1 04/19/18, 18:56
Only master? -
Markus Klein commented on patch set 1 CR -1 04/19/18, 18:57
TcaCheckboxItems.php:150should be labelUnchecked -
TYPO3com voted on patch set 1 V -1 04/19/18, 19:02 Completed build in 08m 23s on Thu, 19 Apr, 09:02 PM Test Summary: 7 of 31204 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-22626
-
Benjamin Kott commented on patch set 2 04/19/18, 20:07
Published edit on patch set 1. -
TYPO3com voted on patch set 2 V +1 04/19/18, 20:17 Completed build in 10m 08s on Thu, 19 Apr, 10:17 PM Test Summary: 31052 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-22630
-
Andreas Kienast updated the commit message in patch set 3 04/19/18, 20:52
-
Andreas Kienast voted on patch set 3 V +1 CR +1 04/19/18, 20:52
-
TYPO3com voted on patch set 3 V +1 04/19/18, 21:03 Completed build in 10m 10s on Thu, 19 Apr, 11:03 PM Test Summary: 31052 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-22635
-
Michael Oehlhof voted on patch set 3 CR +1 04/19/18, 21:34
-
Riny van Tiggelen voted on patch set 3 CR +1 04/20/18, 06:11
-
Jan Delius voted on patch set 3 V +1 CR +1 04/20/18, 07:49
-
Richard Haeser voted on patch set 3 V +1 CR +1 04/20/18, 07:51
-
Jan Stockfisch voted on patch set 3 CR +1 04/20/18, 07:56
-
Markus Klein commented on patch set 3 04/20/18, 10:10
Still my question remains: Why only master and not 8.7? -
Mathias Schreiber commented on patch set 3 04/20/18, 13:05
> Patch Set 3: > > Still my question remains: Why only master and not 8.7? There's a couple of reasons for that. First, I wanted to reduce the workload of the backport. Secondly I wanted to reduce the risk of having a regression. But most importantly because the code does not exist in 8.7 ;-) -
Markus Klein voted on patch set 3 V +2 CR +2 04/20/18, 15:37
-
Markus Klein merged patch set 4 04/20/18, 15:37