Review main Merged

56745[BUGFIX] Make labeledToggleCheckbox localizable

Mathias Schreiber CR +2 V +2 Easy +2 −2 updated 04/20/18, 15:37

Commit message

The labels of a labeledToggleCheckbox are now localizable using
the well known LLL syntax.

Review

  • Code review CR +2
    • Markus Klein +2
    • Jan Delius +1
    • Jan Stockfisch +1
    • Richard Haeser +1
    • Riny van Tiggelen +1
    • Andreas Kienast +1
    • Michael Oehlhof +1
  • Verified V +2
    • Markus Klein +2
    • Jan Delius +1
    • Richard Haeser +1
    • Andreas Kienast +1
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 1518

  1. Mathias Schreiber uploaded patch set 1 04/19/18, 18:54

  2. Markus Klein commented on patch set 1 04/19/18, 18:56

    Only master?
  3. Markus Klein commented on patch set 1 CR -1 04/19/18, 18:57

    TcaCheckboxItems.php:150

    should be labelUnchecked
  4. TYPO3com voted on patch set 1 V -1 04/19/18, 19:02 Completed build in 08m 23s on Thu, 19 Apr, 09:02 PM Test Summary: 7 of 31204 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-22626

  5. Benjamin Kott commented on patch set 2 04/19/18, 20:07

    Published edit on patch set 1.
  6. TYPO3com voted on patch set 2 V +1 04/19/18, 20:17 Completed build in 10m 08s on Thu, 19 Apr, 10:17 PM Test Summary: 31052 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-22630

  7. Andreas Kienast updated the commit message in patch set 3 04/19/18, 20:52

  8. Andreas Kienast voted on patch set 3 V +1 CR +1 04/19/18, 20:52

  9. TYPO3com voted on patch set 3 V +1 04/19/18, 21:03 Completed build in 10m 10s on Thu, 19 Apr, 11:03 PM Test Summary: 31052 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-22635

  10. Michael Oehlhof voted on patch set 3 CR +1 04/19/18, 21:34

  11. Riny van Tiggelen voted on patch set 3 CR +1 04/20/18, 06:11

  12. Jan Delius voted on patch set 3 V +1 CR +1 04/20/18, 07:49

  13. Richard Haeser voted on patch set 3 V +1 CR +1 04/20/18, 07:51

  14. Jan Stockfisch voted on patch set 3 CR +1 04/20/18, 07:56

  15. Markus Klein commented on patch set 3 04/20/18, 10:10

    Still my question remains: Why only master and not 8.7?
  16. Mathias Schreiber commented on patch set 3 04/20/18, 13:05

    > Patch Set 3: > > Still my question remains: Why only master and not 8.7? There's a couple of reasons for that. First, I wanted to reduce the workload of the backport. Secondly I wanted to reduce the risk of having a regression. But most importantly because the code does not exist in 8.7 ;-)
  17. Markus Klein voted on patch set 3 V +2 CR +2 04/20/18, 15:37

  18. Markus Klein merged patch set 4 04/20/18, 15:37