Review main Merged

56747[TASK] Change checkboxes in pages to new rendertype

Ingo Nolden CR +2 V +2 Normal +51 −22 updated 04/30/18, 08:36

Commit message

Some checkboxes are changed to new rendertype checkboxToggle.
Four checkbox labels are added.

Review

  • Code review CR +2
    • Benjamin Kott +2
    • Frank Nägler +1
  • Verified V +2
    • Benjamin Kott +2
    • Frank Nägler +1
    • TYPO3com +1 CI

Issues 2

Files 2

Review log 1723

  1. Ingo Nolden uploaded patch set 1 04/19/18, 19:43

  2. TYPO3com voted on patch set 1 V +1 04/19/18, 19:53 Completed build in 10m 22s on Thu, 19 Apr, 09:53 PM Test Summary: 31052 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-22629

  3. Ingo Nolden commented on patch set 2 04/19/18, 21:18

    Published edit on patch set 1.
  4. TYPO3com voted on patch set 2 V +1 04/19/18, 21:29 Completed build in 10m 27s on Thu, 19 Apr, 11:29 PM Test Summary: 31052 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-22640

  5. Ingo Nolden commented on patch set 3 04/20/18, 19:02

    Published edit on patch set 2.
  6. TYPO3com voted on patch set 3 V +1 04/20/18, 19:16 Completed build in 13m 20s on Fri, 20 Apr, 09:16 PM Test Summary: 31052 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-22717

  7. Dirk Jüttner voted on patch set 3 V +1 CR +1 04/20/18, 19:38

  8. Mathias Schreiber voted on patch set 3 V +1 CR +1 04/21/18, 07:31

  9. Jo Hasenau updated the commit message in patch set 4 04/21/18, 12:36

  10. TYPO3com voted on patch set 4 V +1 04/21/18, 12:55 Completed build in 19m 02s on Sat, 21 Apr, 02:55 PM Test Summary: 31052 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-22789

  11. Dirk Jüttner voted on patch set 4 V -1 CR -1 04/21/18, 16:41

  12. Dirk Jüttner wrote 04/21/18, 16:41

    Removed Verified-1 by Dirk Jüttner <dirk.juettner@gmail.com>
  13. Dirk Jüttner voted on patch set 4 V +1 CR +1 04/21/18, 16:41

  14. Oliver Hader wrote 04/21/18, 18:42

    Topic set to ux-checkboxes
  15. Alexander Opitz uploaded patch set 5 04/25/18, 14:47

  16. Alexander Opitz commented on patch set 5 CR -1 04/25/18, 14:50

    Resolved merge conflict. IMHO the locallang_tca.xlf from frontend is not the correct psoition for this labels (as core do not depend on ext:frontend) maybe the labels should also moved here typo3/sysext/core/Resources/Private/Language/locallang_tca.xlf
  17. TYPO3com voted on patch set 5 V +1 04/25/18, 14:57 Completed build in 10m 05s on Wed, 25 Apr, 04:57 PM Test Summary: 31061 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-22902

  18. Frank Nägler rebased onto patch set 6 04/27/18, 08:52

  19. Frank Nägler voted on patch set 6 V +1 CR +1 04/27/18, 09:00

  20. TYPO3com voted on patch set 6 V +1 04/27/18, 09:04 Completed build in 11m 45s on Fri, 27 Apr, 11:04 AM Test Summary: 31061 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-22957

  21. Benjamin Kott voted on patch set 6 V +2 CR +2 04/27/18, 09:06

  22. Benjamin Kott merged patch set 7 04/27/18, 09:06

  23. Alexander Opitz commented on patch set 7 04/30/18, 08:36

    Post -1, the labels are still in frontend locallang, which should be avoid IMHO.