Review TYPO3_8-7 Merged

56748[BUGFIX] Check if file exists for backend logo

Andreas Kienast CR +2 V +2 Easy +1 −1 updated 04/19/18, 21:21

Commit message

If an invalid file path is given, an exception is thrown if trying to
access its properties and the backend is not accessible any more.
Check if file exists before accessing. If not use default.

Review

  • Code review CR +2
    • Andreas Kienast +2
  • Verified V +2
    • Andreas Kienast +2
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 35

  1. Andreas Kienast commented on patch set 1 04/19/18, 20:57

    Cherry Picked from branch master.
  2. TYPO3com voted on patch set 1 V -1 04/19/18, 21:11 Completed build in 13m 56s on Thu, 19 Apr, 11:11 PM Test Summary: 1 of 58722 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC87-2335

  3. TYPO3com voted on patch set 1 V +1 04/19/18, 21:21 Completed build in 37m 06s on Thu, 19 Apr, 11:21 PM Test Summary: 58383 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC87-2335

  4. Andreas Kienast voted on patch set 1 V +2 CR +2 04/19/18, 21:21

  5. Andreas Kienast merged patch set 2 04/19/18, 21:21