Review main Abandoned

56750[TASK] add scripts to composer.json to allow easier onboarding

Kay Strobach CR 0 V 0 Normal +64 −1 updated 04/20/18, 10:01

Commit message

Review

  • Code review CR 0
  • Verified V 0

Issues 1

Files 1

Review log 79

  1. Kay Strobach uploaded patch set 1 04/20/18, 09:45

  2. TYPO3com voted on patch set 1 V -1 04/20/18, 09:45 Completed build in 10s on Fri, 20 Apr, 11:45 AM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-22648

  3. Mathias Brodala commented on patch set 1 04/20/18, 09:49

    composer.json:248

    Please use names like "howto:contribute" since this allows for shorting to "h:c" on CLI thanks to Symfony Console.
  4. Mathias Brodala commented on patch set 1 04/20/18, 09:52

    BTW, how about adding these to https://review.typo3.org/54959 instead?
  5. Kay Strobach uploaded patch set 2 04/20/18, 09:54

  6. TYPO3com voted on patch set 2 V -1 04/20/18, 09:54 Completed build in 10s on Fri, 20 Apr, 11:54 AM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-22649

  7. Sybille Peters commented on patch set 2 04/20/18, 09:57

    Please look at reviews https://review.typo3.org/c/54959/ (Mathias Brodala) and https://review.typo3.org/c/54959/ (Sybille Peters) to see if there is anything there you can use. I am now closing my review. Thanks for working on this. Please update contributon guide when you are done.
  8. Kay Strobach commented on patch set 2 V -1 CR -1 04/20/18, 10:01

  9. Kay Strobach abandoned the change 04/20/18, 10:01