Review main Merged

56752[BUGFIX] Always exclude E_USER_DEPRECATED from exceptionalErrors

Helmut Hummel CR +2 V +2 Easy +5 −2 updated 04/21/18, 12:26

Commit message

There is a limited use case for exceptions to be thrown
on deprecation messages. To ease the upgrade path to TYPO3 9
and to not allow "accidental" configuration that breaks the system,
deprecation messages will never throw exceptions.

Users with other use cases, can still implement and configure their
own exception handler.

Review

  • Code review CR +2
    • Helmut Hummel +2
    • Mathias Schreiber +1
    • Markus Klein +1
    • Jan Stockfisch +1
  • Verified V +2
    • Helmut Hummel +2
    • Mathias Schreiber +1
    • Markus Klein +1
    • TYPO3com +1 CI

Issues 1

Files 2

Review log 1217

  1. Helmut Hummel uploaded patch set 1 04/20/18, 10:32

  2. Helmut Hummel commented on patch set 1 04/20/18, 10:33

    ErrorHandler.php:68

    we might be able to remove the cast, but have not checked on that yet
  3. Helmut Hummel updated the commit message in patch set 2 04/20/18, 10:34

  4. Helmut Hummel updated the commit message in patch set 3 04/20/18, 10:34

  5. TYPO3com voted on patch set 1 V +1 04/20/18, 10:41 Completed build in 09m 06s on Fri, 20 Apr, 12:41 PM Test Summary: 31052 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-22653

  6. TYPO3com voted on patch set 2 V +1 04/20/18, 10:44 Completed build in 09m 44s on Fri, 20 Apr, 12:44 PM Test Summary: 31052 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-22654

  7. TYPO3com voted on patch set 3 V +1 04/20/18, 10:47 Completed build in 12m 26s on Fri, 20 Apr, 12:47 PM Test Summary: 31052 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-22655

  8. Markus Klein commented on patch set 4 04/20/18, 10:56

    Published edit on patch set 3.
  9. Markus Klein voted on patch set 4 V +1 CR +1 04/20/18, 10:56

  10. Markus Klein commented on patch set 5 04/20/18, 10:57

    Published edit on patch set 4.
  11. Markus Klein voted on patch set 5 V +1 CR +1 04/20/18, 10:57

  12. TYPO3com voted on patch set 4 V +1 04/20/18, 11:06 Completed build in 10m 53s on Fri, 20 Apr, 01:06 PM Test Summary: 31052 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-22658

  13. TYPO3com voted on patch set 5 V +1 04/20/18, 11:08 Completed build in 10m 49s on Fri, 20 Apr, 01:08 PM Test Summary: 31052 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-22659

  14. Jan Stockfisch voted on patch set 5 CR +1 04/20/18, 11:13

  15. Mathias Schreiber voted on patch set 5 V +1 CR +1 04/21/18, 12:17

  16. Helmut Hummel commented on patch set 5 V +2 CR +2 04/21/18, 12:26

    Thanks for the reviews!
  17. Helmut Hummel merged patch set 6 04/21/18, 12:26