56753[TASK] Remove unused 'ISOcode' field in getSystemLanguages
Commit message
Review
-
Code review CR 0
-
Verified V 0
Issues 1
Files 1
Review log 1012
-
Alexander Opitz uploaded patch set 1 04/20/18, 12:46
-
TYPO3com voted on patch set 1 V -1 04/20/18, 12:46 Completed build in 10s on Fri, 20 Apr, 02:46 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-22670
-
Alexander Opitz uploaded patch set 2 04/20/18, 12:50
-
TYPO3com voted on patch set 2 V +1 04/20/18, 13:01 Completed build in 11m 29s on Fri, 20 Apr, 03:01 PM Test Summary: 31052 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-22673
-
Andreas Kienast commented on patch set 2 CR -1 04/20/18, 13:10
This is a breaking change. -
Mathias Brodala commented on patch set 2 05/14/18, 14:37
How to proceed here? If the field is in use with static_info_tables then I actually expect quite some impact given that that extension is widely used. In that case we need to start with a deprecation. -
Alexander Opitz commented on patch set 2 05/14/18, 21:37
Please read the description of the issue to this commit. This field isn't in use by static_info_tables, but it is filled with data from there, if the extension exists, but it isn't used inside core. -
Andreas Kienast commented on patch set 2 05/15/18, 06:36
That still qualifies as a breaking change and my comment remains. -
Benni Mack commented on patch set 2 10/28/18, 13:39
we won't do a breaking change with v9 anymore, but I see that we remove this place PLUS the other dependencies on static_info_tables in v10, as we don't need this anymore (at all) -
Benni Mack commented on patch set 2 12/14/18, 10:02
let's use this one to remove all other static_info_tables information -
Benni Mack commented on patch set 2 06/05/19, 10:11
This change is not necessary anymore, the code was removed as Site Handling now is the only part that evaluates the ISOcode in v10. So we can abandon this issue and close the ticket. OK with everybody? -
Benni Mack abandoned the change 06/27/19, 14:28
see last message