Review main Merged

56756[TASK] Change checkboxes in sys_file_storage

Ingo Nolden CR +2 V +2 Normal +41 −16 updated 04/27/18, 15:45

Commit message

Some checkboxes are changed to new rendertype checkboxToggle.
One checkbox is type => user and the rendering is adapted
in the userFunc.

Review

  • Code review CR +2
    • Georg Ringer +2
    • Frank Nägler +1
  • Verified V +2
    • Georg Ringer +2
    • Frank Nägler +1
    • TYPO3com +1 CI

Issues 2

Files 2

Review log 1117

  1. Ingo Nolden uploaded patch set 1 04/20/18, 14:10

  2. TYPO3com voted on patch set 1 V -1 04/20/18, 14:10 Completed build in 10s on Fri, 20 Apr, 04:10 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-22682

  3. Ingo Nolden updated the commit message in patch set 2 04/20/18, 14:25

  4. TYPO3com voted on patch set 2 V -1 04/20/18, 14:25 Completed build in 10s on Fri, 20 Apr, 04:25 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-22685

  5. Ingo Nolden updated the commit message in patch set 3 04/20/18, 17:52

  6. TYPO3com voted on patch set 3 V -1 04/20/18, 17:53 Completed build in 09s on Fri, 20 Apr, 07:53 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-22709

  7. Ingo Nolden commented on patch set 4 04/20/18, 19:09

    Published edit on patch set 3.
  8. TYPO3com voted on patch set 4 V -1 04/20/18, 19:10 Completed build in 50s on Fri, 20 Apr, 09:10 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-22720

  9. Ingo Nolden commented on patch set 5 04/21/18, 07:57

    Published edit on patch set 4.
  10. TYPO3com voted on patch set 5 V -1 04/21/18, 08:11 Completed build in 13m 31s on Sat, 21 Apr, 10:11 AM Test Summary: 1 of 31204 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-22749

  11. Dirk Jüttner commented on patch set 5 CR -1 04/21/18, 08:58

    Is the onclick event in line 92 already needed like this? typo3/sysext/core/Classes/Resource/Service/UserStorageCapabilityService.php

    UserStorageCapabilityService.php:93

    Is the onclick event already needed like this?
  12. Oliver Hader wrote 04/21/18, 18:42

    Topic set to ux-checkboxes
  13. Frank Nägler rebased onto patch set 6 04/27/18, 09:19

  14. TYPO3com voted on patch set 6 V +1 04/27/18, 09:28 Completed build in 09m 21s on Fri, 27 Apr, 11:28 AM Test Summary: 31061 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-22962

  15. Frank Nägler voted on patch set 6 V +1 CR +1 04/27/18, 09:33

  16. Georg Ringer voted on patch set 6 V +2 CR +2 04/27/18, 15:45

  17. Georg Ringer merged patch set 7 04/27/18, 15:45