Review main Merged

56761[TASK] Change checkboxes in EXT:frontend TCA files

Ingo Nolden CR +2 V +2 Normal +52 −13 updated 04/26/18, 14:29

Commit message

Some checkboxes are changed to new rendertype checkboxToggle in:
sys_domain
sys_template
backend_layout

Review

  • Code review CR +2
    • Frank Nägler +2
    • Alexander Opitz +1
    • Jörg Bösche +1
  • Verified V +2
    • Frank Nägler +2
    • Alexander Opitz +1
    • TYPO3com +1 CI

Issues 2

Files 3

Review log 1723

  1. Ingo Nolden uploaded patch set 1 04/20/18, 16:18

  2. TYPO3com voted on patch set 1 V +1 04/20/18, 16:28 Completed build in 10m 50s on Fri, 20 Apr, 06:28 PM Test Summary: 31052 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-22704

  3. Ingo Nolden commented on patch set 2 04/20/18, 19:12

    Published edit on patch set 1.
  4. TYPO3com voted on patch set 2 V +1 04/20/18, 19:27 Completed build in 15m 02s on Fri, 20 Apr, 09:27 PM Test Summary: 31052 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-22722

  5. Dirk Jüttner commented on patch set 2 CR -1 04/21/18, 12:03

    sys_template.php:173

    'renderType' => 'checkboxToggle', 'items' => [ [ 0 => '', 1 => '', ] ], is missing here
  6. Jo Hasenau updated the commit message in patch set 3 04/21/18, 12:34

  7. TYPO3com voted on patch set 3 V +1 04/21/18, 12:52 Completed build in 18m 23s on Sat, 21 Apr, 02:52 PM Test Summary: 31052 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-22788

  8. Andreas Kienast uploaded patch set 4 04/21/18, 12:57

  9. TYPO3com voted on patch set 4 V +1 04/21/18, 13:15 Completed build in 17m 53s on Sat, 21 Apr, 03:15 PM Test Summary: 31052 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-22797

  10. Oliver Hader wrote 04/21/18, 18:42

    Topic set to ux-checkboxes
  11. Dirk Jüttner voted on patch set 4 V +1 CR +1 04/23/18, 17:13

  12. Jörg Bösche voted on patch set 4 V +1 CR +1 04/24/18, 09:41

  13. Alexander Opitz commented on patch set 4 CR -1 04/25/18, 16:17

    I'm on it
  14. Alexander Opitz uploaded patch set 5 04/25/18, 16:20

  15. Alexander Opitz commented on patch set 5 04/25/18, 16:22

    Resolve merge conflicts

    sys_template.php:86

    'default' => 0 is missing
  16. Alexander Opitz uploaded patch set 6 04/25/18, 16:23

  17. Alexander Opitz commented on patch set 5 04/25/18, 16:24

    sys_template.php:86 Reply

    Done
  18. Alexander Opitz voted on patch set 6 V +1 CR +1 04/25/18, 16:24

  19. TYPO3com voted on patch set 5 V +1 04/25/18, 16:29 Completed build in 09m 30s on Wed, 25 Apr, 06:29 PM Test Summary: 31061 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-22910

  20. TYPO3com voted on patch set 6 V +1 04/25/18, 16:36 Completed build in 13m 07s on Wed, 25 Apr, 06:36 PM Test Summary: 31061 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-22911

  21. Jörg Bösche voted on patch set 6 CR +1 04/26/18, 13:25

  22. Frank Nägler voted on patch set 6 V +2 CR +2 04/26/18, 14:29

  23. Frank Nägler merged patch set 7 04/26/18, 14:29