56762[TASK] Change checkboxes in fe_users and fe_groups
Commit message
Review
-
Code review CR +2
- Frank Nägler +2
- Alexander Opitz +1
-
Verified V +2
- Frank Nägler +2
- Alexander Opitz +1
- TYPO3com +1 CI
Issues 2
Files 2
Review log 1621
-
Ingo Nolden uploaded patch set 1 04/20/18, 16:27
-
TYPO3com voted on patch set 1 V +1 04/20/18, 16:37 Completed build in 09m 57s on Fri, 20 Apr, 06:37 PM Test Summary: 31052 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-22706
-
Ingo Nolden commented on patch set 2 04/20/18, 19:13
Published edit on patch set 1. -
TYPO3com voted on patch set 2 V +1 04/20/18, 19:29 Completed build in 16m 16s on Fri, 20 Apr, 09:29 PM Test Summary: 31052 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-22723
-
Dirk Jüttner voted on patch set 2 V +1 CR +1 04/21/18, 12:13
-
Jo Hasenau updated the commit message in patch set 3 04/21/18, 12:33
-
Andreas Kienast uploaded patch set 4 04/21/18, 12:48
-
Andreas Kienast voted on patch set 4 V +1 CR +1 04/21/18, 12:48
-
TYPO3com voted on patch set 3 V -1 04/21/18, 12:49 Completed build in 16m 04s on Sat, 21 Apr, 02:49 PM Test Summary: 1 of 31204 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-22787
-
TYPO3com voted on patch set 4 V +1 04/21/18, 13:11 Completed build in 22m 59s on Sat, 21 Apr, 03:11 PM Test Summary: 31052 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-22795
-
Oliver Hader wrote 04/21/18, 18:42
Topic set to ux-checkboxes -
Dirk Jüttner voted on patch set 4 V +1 CR +1 04/23/18, 17:16
-
Jörg Bösche voted on patch set 4 V +1 CR +1 04/24/18, 09:38
-
Alexander Opitz commented on patch set 4 CR -1 04/25/18, 16:26
On it -
Alexander Opitz uploaded patch set 5 04/25/18, 16:29
-
Alexander Opitz voted on patch set 5 V +1 CR +1 04/25/18, 16:30
-
TYPO3com voted on patch set 5 V +1 04/25/18, 16:41 Completed build in 11m 27s on Wed, 25 Apr, 06:41 PM Test Summary: 31061 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-22914
-
Jigal van Hemert commented on patch set 5 04/26/18, 11:26
This looks really confusing. The grey and green have the same brightness and it's very unclear what the switch positions left and right mean. Accessibility guidelines tell us to not use colour alone to convey the message. The checkbox had at least a symbol that told that the option was active. -
Frank Nägler commented on patch set 5 V +2 CR +2 04/26/18, 12:44
@Jigal: that is correct, but the patch it self works. The color / accessibility thingy must be fixed in an own patch. I have created an issue for the problem: https://forge.typo3.org/issues/84881 -
Frank Nägler merged patch set 6 04/26/18, 12:44
-
Jigal van Hemert commented on patch set 6 04/26/18, 15:56
Post merge -1 for incorrect labelsfe_groups.php:26"disable" and "enableD" are not opposites. Especially in translations it will give unexpected results.