Review main Merged

56768[TASK] Change checkboxes in tx_scheduler_task_group and index_config

Ingo Nolden CR +2 V +2 Easy +40 −10 updated 04/27/18, 10:27

Commit message

Some checkboxes are changed to new rendertype checkboxToggle.

Review

  • Code review CR +2
    • Benjamin Kott +2
    • Frank Nägler +1
  • Verified V +2
    • Benjamin Kott +2
    • Frank Nägler +1
    • TYPO3com +1 CI

Issues 2

Files 2

Review log 1723

  1. Ingo Nolden uploaded patch set 1 04/20/18, 20:35

  2. TYPO3com voted on patch set 1 V +1 04/20/18, 20:44 Completed build in 08m 42s on Fri, 20 Apr, 10:44 PM Test Summary: 31052 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-22735

  3. Mathias Schreiber voted on patch set 1 V +1 CR +1 04/21/18, 07:29

  4. Jo Hasenau updated the commit message in patch set 2 04/21/18, 12:30

  5. Jo Hasenau voted on patch set 2 CR +1 04/21/18, 12:41

  6. TYPO3com voted on patch set 2 V +1 04/21/18, 12:46 Completed build in 15m 41s on Sat, 21 Apr, 02:46 PM Test Summary: 31052 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-22786

  7. Andreas Kienast uploaded patch set 3 04/21/18, 12:52

  8. Andreas Kienast voted on patch set 3 V +1 CR +1 04/21/18, 12:52

  9. TYPO3com voted on patch set 3 V +1 04/21/18, 13:13 Completed build in 21m 06s on Sat, 21 Apr, 03:13 PM Test Summary: 31052 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-22796

  10. Dirk Jüttner commented on patch set 3 CR -1 04/21/18, 15:32

    tx_scheduler_task_group.php:53

    'default' => 0 is missing
  11. Ingo Nolden commented on patch set 4 04/21/18, 17:42

    Published edit on patch set 3.
  12. TYPO3com voted on patch set 4 V +1 04/21/18, 17:55 Completed build in 12m 47s on Sat, 21 Apr, 07:55 PM Test Summary: 31052 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-22812

  13. Oliver Hader wrote 04/21/18, 18:41

    Topic set to ux-checkboxes
  14. Dirk Jüttner voted on patch set 4 CR +1 04/23/18, 18:33

  15. Jigal van Hemert commented on patch set 1 04/26/18, 16:08

    index_config.php:25

    "disable" and "enableD" are not opposites. Especially in translations this will produce confusing results.
  16. Frank Nägler uploaded patch set 5 04/27/18, 08:42

  17. Frank Nägler voted on patch set 5 V +1 CR +1 04/27/18, 08:44

  18. TYPO3com voted on patch set 5 V +1 04/27/18, 08:50 Completed build in 07m 59s on Fri, 27 Apr, 10:50 AM Test Summary: 31061 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-22955

  19. Frank Nägler uploaded patch set 6 04/27/18, 08:55

  20. TYPO3com voted on patch set 6 V +1 04/27/18, 09:07 Completed build in 12m 51s on Fri, 27 Apr, 11:07 AM Test Summary: 31061 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-22959

  21. Frank Nägler voted on patch set 6 V +1 CR +1 04/27/18, 09:30

  22. Benjamin Kott voted on patch set 6 V +2 CR +2 04/27/18, 10:27

  23. Benjamin Kott merged patch set 7 04/27/18, 10:27