56773[BUGFIX] Skip adding child elements if a nested form element is unknown
Commit message
Review
-
Code review CR +2
- Mathias Brodala +2
- Björn Jacob +1
- Frank Nägler +1
-
Verified V +2
- Mathias Brodala +2
- Björn Jacob +1
- Frank Nägler +1
- TYPO3com +1 CI
Issues 1
Files 2
Review log 2431
Show 56 earlier messages
-
Ralf Zimmermann uploaded patch set 1 04/21/18, 08:11
-
Wouter Wolters voted on patch set 1 CR +1 04/21/18, 08:16
-
Oliver Klee commented on patch set 1 04/21/18, 08:18
Would it make sense to cover this case with tests? -
TYPO3com voted on patch set 1 V +1 04/21/18, 08:21 Completed build in 09m 29s on Sat, 21 Apr, 10:21 AM Test Summary: 31052 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-22753
-
Björn Jacob commented on patch set 1 04/21/18, 08:38
This happens in v8 as well. So let's backport it. -
Ralf Zimmermann updated the commit message in patch set 2 04/21/18, 09:11
-
TYPO3com voted on patch set 2 V +1 04/21/18, 09:19 Completed build in 08m 08s on Sat, 21 Apr, 11:19 AM Test Summary: 31052 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-22762
-
Ralf Zimmermann uploaded patch set 3 04/21/18, 13:45
-
TYPO3com voted on patch set 3 V -1 04/21/18, 13:46 Completed build in 10s on Sat, 21 Apr, 03:46 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-22800
-
Ralf Zimmermann uploaded patch set 4 04/21/18, 13:47
-
TYPO3com voted on patch set 4 V +1 04/21/18, 13:56 Completed build in 08m 52s on Sat, 21 Apr, 03:56 PM Test Summary: 31055 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-22801
-
Ralf Zimmermann uploaded patch set 5 04/21/18, 18:11
-
TYPO3com voted on patch set 5 V +1 04/21/18, 18:19 Completed build in 08m 28s on Sat, 21 Apr, 08:19 PM Test Summary: 31058 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-22814
-
Massimiliano Fani voted on patch set 5 CR +1 05/10/18, 15:51
-
Susi Moog commented on patch set 5 CR -1 05/11/18, 09:42
should probably be "if"ArrayFormFactoryTest.php:49can you make it clearer what the assertion part of this test is? -
Ralf Zimmermann uploaded patch set 6 05/13/18, 11:06
-
TYPO3com voted on patch set 6 V +1 05/13/18, 11:13 Completed build in 07m 30s on Sun, 13 May, 01:13 PM Test Summary: 31159 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-23428
-
Mathias Brodala commented on patch set 6 05/14/18, 13:58
ArrayFormFactory.php:115This feels a bit odd given that $renderable is the result of internal API calls. Maybe this check should be done above and a proper UnknownCompositRenderableException being thrown? -
Ralf Zimmermann commented on patch set 6 05/15/18, 06:12
> Patch Set 6: > > (1 comment) $renderable = $parentRenderable->createElement($nestedRenderableConfiguration['identifier'], $nestedRenderableConfiguration['type']); creates a form element OR creates an "UnknownFormElement" if you configured it, otherwise a TypeDefinitionNotFoundException will be thrown. The option "skipUnknownElements" means something like "should i throw an exception if there is no existing type definition for this form element type" (https://github.com/TYPO3/TYPO3.CMS/blob/master/typo3/sysext/form/Classes/Domain/Model/FormElements/AbstractSection.php#L119). Since $parentRenderable does not necessarily have to extend from AbstractSection, because you can create your own section implementation with custom createElement() logic we can not ensure that an "UnknownFormElement" is created or a TypeDefinitionNotFoundException will be thrown. In this case the UnknownCompositRenderableException will be thrown. If the form definition contains a "section like" form element type "xyz" it has configured "renderables". If the form element type "xyz" has no existing type definition and the option "skipUnknownElements" is true, the form element is transformed into a "UnknownFormElement" (AbstractSection.php#L119) For this we need to check if the "target" $renderable after the $parentRenderable->createElement() API call is already an CompositRenderable. If not we need to skip the creation of child renderables but must not throw an exception because "skipUnknownElements" should prevent this. -
Susi Moog voted on patch set 6 CR +1 05/16/18, 10:42
-
Björn Jacob voted on patch set 6 V +1 05/16/18, 13:05
-
Björn Jacob voted on patch set 6 CR +1 05/16/18, 13:32
-
Björn Jacob rebased onto patch set 7 05/16/18, 15:16
-
TYPO3com voted on patch set 7 V +1 05/16/18, 15:27 Completed build in 10m 23s on Wed, 16 May, 05:27 PM Test Summary: 31159 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-23550
-
Björn Jacob voted on patch set 7 V +1 CR +1 05/16/18, 16:25
-
Kay Strobach commented on patch set 6 05/18/18, 08:58
ArrayFormFactory.php:115Replystill valid in the last patch set -
Susi Moog commented on patch set 6 05/18/18, 09:44
ArrayFormFactory.php:115Replysee Ralfs long comment on Patch Set 6 itself. -
Frank Nägler voted on patch set 7 V +1 CR +1 05/18/18, 10:00
-
Mathias Brodala voted on patch set 7 V +2 CR +2 05/18/18, 10:03
-
Mathias Brodala merged patch set 8 05/18/18, 10:03
-
Mathias Brodala commented on patch set 8 05/22/18, 07:27
Cherry Picked This patchset was cherry picked to branch TYPO3_8-7 as commit 8d8811c84ac622d2679a326e34769e424dbd0080