Review main Abandoned

56784[BUGFIX] Respect escaping for autocomplete

Guido Schmechel CR 0 V 0 Easy +2 −0 updated 10/27/18, 15:22

Commit message

Make it possible to use escaped TypoScript values like
page.meta.foo\.bar = baz for autocompletion.

Review

  • Code review CR 0
  • Verified V 0

Issues 1

Files 1

Review log 1112

  1. Guido Schmechel uploaded patch set 1 04/23/18, 19:56

  2. TYPO3com voted on patch set 1 V +1 04/23/18, 20:04 Completed build in 08m 11s on Mon, 23 Apr, 10:04 PM Test Summary: 31052 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-22843

  3. Georg Ringer voted on patch set 1 V +1 CR +1 04/24/18, 00:13

  4. Jörg Bösche voted on patch set 1 CR +1 04/24/18, 06:03

  5. Benni Mack commented on patch set 1 04/24/18, 07:24

    I wonder if we should move this into TypoScriptParser. Also we need tests, as someone might have this page.meta.foo.bar = bar\.baz which could be intended?
  6. Guido Schmechel commented on patch set 1 04/24/18, 07:34

    Hi Benni, What would be your favorite code position? I'm also not really happy about this change, but at the treeWalkup() call the typoscript setup is already parsed.
  7. Oliver Klee commented on patch set 1 05/01/18, 10:14

    Can/should we cover this with a test?
  8. Jigal van Hemert commented on patch set 1 05/01/18, 21:46

    I tend to give a -1, but that might seem a bit harsh. We definitely need tests to make sure it doesn't affect handling of escaped dots in key names.

    TemplateService.php:1138

    In parse() just below the escaped dots are needed to handle dots in key segment (in parseNextKeySegment()). If the escaped dots are replaced already parsing will not handle these key correctly IMO.
  9. Guido Schmechel commented on patch set 1 05/02/18, 08:51

    Tests would be necessary, right. For me it was only important, if this place in the code is right. A "-1" would be okay, because the tests are missing ;-)
  10. Jigal van Hemert voted on patch set 1 CR -1 05/04/18, 19:18

  11. Guido Schmechel commented on patch set 1 05/06/18, 15:39

    I have invested some more time and you are right with the parsing. As it seems, this does not seem to be a topic for a beginner.
  12. Benni Mack abandoned the change 10/27/18, 15:22

    Hey Guido, thanks for taking the time. I'll close this patch set, but keep the issue (where this review is linked to) here for the time being, so somebody at some point in time can take another fresh look at this. Thanks for the investigation very much!