56792[TASK] Replace TYPO3_OS constant with Environment check
Commit message
Review
-
Code review CR +2
- Tymoteusz Motylewski +2
- Susi Moog +1
-
Verified V +2
- Tymoteusz Motylewski +2
- Susi Moog +1
- TYPO3com +1 CI
Issues 1
Files 23
- typo3/sysext/core/Classes/Cache/Backend/SimpleFileBackend.php+3 −3
- typo3/sysext/core/Classes/Utility/CommandUtility.php+7 −5
- typo3/sysext/core/Classes/Utility/ExtensionManagementUtility.php+2 −1
- typo3/sysext/core/Classes/Utility/GeneralUtility.php+4 −4
- typo3/sysext/core/Classes/Utility/PathUtility.php+4 −18
- typo3/sysext/core/Tests/Unit/Locking/SimpleLockStrategyTest.php+1 −1
- typo3/sysext/core/Tests/Unit/Resource/Driver/LocalDriverTest.php+5 −4
- typo3/sysext/core/Tests/Unit/Utility/Fixtures/WindowsPathUtilityFixture.phpdeleted+0 −33
- typo3/sysext/core/Tests/Unit/Utility/GeneralUtilityTest.php+18 −17
- typo3/sysext/core/Tests/Unit/Utility/PathUtilityTest.php+27 −7
- typo3/sysext/extensionmanager/Classes/Utility/FileHandlingUtility.php+1 −1
- typo3/sysext/indexed_search/Classes/FileContentParser.php+2 −1
- typo3/sysext/install/Classes/Configuration/Image/GraphicsMagickPreset.php+3 −1
- typo3/sysext/install/Classes/Configuration/Image/ImageMagick6Preset.php+3 −1
- typo3/sysext/install/Classes/Controller/EnvironmentController.php+3 −2
- typo3/sysext/install/Classes/FolderStructure/AbstractNode.php+2 −4
- typo3/sysext/install/Classes/FolderStructure/DefaultPermissionsCheck.php+2 −1
- typo3/sysext/install/Classes/Service/CoreUpdateService.php+1 −1
- typo3/sysext/install/Classes/SystemEnvironment/SetupCheck.php+4 −3
- typo3/sysext/reports/Classes/Report/Status/ConfigurationStatus.php+2 −1
Review log 1216
-
Benni Mack uploaded patch set 1 04/25/18, 04:26
-
TYPO3com voted on patch set 1 V -1 04/25/18, 04:35 Completed build in 09m 09s on Wed, 25 Apr, 06:35 AM Test Summary: 3 of 31204 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-22863
-
Wouter Wolters commented on patch set 1 04/25/18, 07:09
PathUtilityTest fails -
Benni Mack uploaded patch set 2 04/25/18, 14:38
-
TYPO3com voted on patch set 2 V -1 04/25/18, 14:47 Completed build in 09m 11s on Wed, 25 Apr, 04:47 PM Test Summary: 138 of 31213 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-22900
-
Anja Leichsenring commented on patch set 2 04/25/18, 15:08
on it -
Benni Mack uploaded patch set 3 04/26/18, 04:22
-
Tymoteusz Motylewski rebased onto patch set 4 04/26/18, 15:20
-
Tymoteusz Motylewski commented on patch set 4 04/26/18, 15:20
rebased to get bamboo vote -
Tymoteusz Motylewski voted on patch set 4 CR +1 04/26/18, 15:20
-
TYPO3com voted on patch set 4 V -1 04/26/18, 15:29 Completed build in 08m 59s on Thu, 26 Apr, 05:29 PM Test Summary: 31061 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-22945
-
Susi Moog uploaded patch set 5 04/26/18, 16:08
-
TYPO3com voted on patch set 5 V +1 04/26/18, 16:19 Completed build in 11m 06s on Thu, 26 Apr, 06:19 PM Test Summary: 31061 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-22948
-
Susi Moog voted on patch set 5 V +1 CR +1 04/26/18, 16:21
-
Tymoteusz Motylewski voted on patch set 5 V +2 CR +2 04/26/18, 16:37
-
Tymoteusz Motylewski merged patch set 6 04/26/18, 16:37