Review main Merged

56792[TASK] Replace TYPO3_OS constant with Environment check

Benni Mack CR +2 V +2 Normal +99 −112 updated 04/26/18, 16:37

Commit message

In order to move away from using hard-coded constants,
the Environment class method "isWindows" is used.

Review

  • Code review CR +2
    • Tymoteusz Motylewski +2
    • Susi Moog +1
  • Verified V +2
    • Tymoteusz Motylewski +2
    • Susi Moog +1
    • TYPO3com +1 CI

Issues 1

Files 23

Show 3 more files

Review log 1216

  1. Benni Mack uploaded patch set 1 04/25/18, 04:26

  2. TYPO3com voted on patch set 1 V -1 04/25/18, 04:35 Completed build in 09m 09s on Wed, 25 Apr, 06:35 AM Test Summary: 3 of 31204 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-22863

  3. Wouter Wolters commented on patch set 1 04/25/18, 07:09

    PathUtilityTest fails
  4. Benni Mack uploaded patch set 2 04/25/18, 14:38

  5. TYPO3com voted on patch set 2 V -1 04/25/18, 14:47 Completed build in 09m 11s on Wed, 25 Apr, 04:47 PM Test Summary: 138 of 31213 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-22900

  6. Anja Leichsenring commented on patch set 2 04/25/18, 15:08

    on it
  7. Benni Mack uploaded patch set 3 04/26/18, 04:22

  8. Tymoteusz Motylewski rebased onto patch set 4 04/26/18, 15:20

  9. Tymoteusz Motylewski commented on patch set 4 04/26/18, 15:20

    rebased to get bamboo vote
  10. Tymoteusz Motylewski voted on patch set 4 CR +1 04/26/18, 15:20

  11. TYPO3com voted on patch set 4 V -1 04/26/18, 15:29 Completed build in 08m 59s on Thu, 26 Apr, 05:29 PM Test Summary: 31061 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-22945

  12. Susi Moog uploaded patch set 5 04/26/18, 16:08

  13. TYPO3com voted on patch set 5 V +1 04/26/18, 16:19 Completed build in 11m 06s on Thu, 26 Apr, 06:19 PM Test Summary: 31061 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-22948

  14. Susi Moog voted on patch set 5 V +1 CR +1 04/26/18, 16:21

  15. Tymoteusz Motylewski voted on patch set 5 V +2 CR +2 04/26/18, 16:37

  16. Tymoteusz Motylewski merged patch set 6 04/26/18, 16:37