Review main Merged

56804[BUGFIX] Correctly check for a key in getPageForRootline

Tymoteusz Motylewski CR +2 V +2 Easy +1 −1 updated 04/26/18, 04:24

Commit message

Move coalescing operator to inside is_array. It was was introduced
in https://review.typo3.org/#/c/54558/

Review

  • Code review CR +2
    • Benni Mack +2
    • Wouter Wolters +1
    • Guido Schmechel +1
    • Riny van Tiggelen +1
    • Andreas Kienast +1
  • Verified V +2
    • Benni Mack +2
    • Andreas Kienast +1
    • TYPO3com +1 CI

Issues 2

Files 1

Review log 1012

  1. Tymoteusz Motylewski uploaded patch set 1 04/25/18, 10:59

  2. Benni Mack voted on patch set 1 CR +1 04/25/18, 11:02

  3. TYPO3com voted on patch set 1 V +1 04/25/18, 11:09 Completed build in 10m 20s on Wed, 25 Apr, 01:09 PM Test Summary: 31061 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-22893

  4. Wouter Wolters updated the commit message in patch set 2 04/25/18, 11:17

  5. Wouter Wolters voted on patch set 2 CR +1 04/25/18, 11:17

  6. TYPO3com voted on patch set 2 V +1 04/25/18, 11:25 Completed build in 08m 10s on Wed, 25 Apr, 01:25 PM Test Summary: 31061 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-22895

  7. Riny van Tiggelen voted on patch set 2 CR +1 04/25/18, 11:51

  8. Guido Schmechel voted on patch set 2 CR +1 04/25/18, 18:34

  9. Andreas Kienast voted on patch set 2 V +1 CR +1 04/25/18, 19:23

  10. Benni Mack voted on patch set 2 V +2 CR +2 04/26/18, 04:23

  11. Benni Mack merged patch set 3 04/26/18, 04:23

  12. Benni Mack commented on patch set 3 04/26/18, 04:24

    Looks like this is fixed in 8.7 already - no backport