Review main Merged

56805[BUGFIX] Ensure webmounts in list module are calculated only once

Benni Mack CR +2 V +2 Easy +23 −15 updated 04/26/18, 06:06

Commit message

When using the backend search the list module is fetching the list of
PIDs to recursively look for every single TCA table.

A runtime cache is added in order to only look up this information once
per request.

Review

  • Code review CR +2
    • Georg Ringer +2
    • Stephan Großberndt +1
    • Daniel Gorges +1
  • Verified V +2
    • Georg Ringer +2
    • Daniel Gorges +1
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 911

  1. Benni Mack uploaded patch set 1 04/25/18, 13:50

  2. TYPO3com voted on patch set 1 V +1 04/25/18, 13:58 Completed build in 08m 01s on Wed, 25 Apr, 03:58 PM Test Summary: 31061 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-22897

  3. Stephan Großberndt updated the commit message in patch set 2 04/25/18, 14:15

  4. Stephan Großberndt voted on patch set 2 CR +1 04/25/18, 14:15

  5. TYPO3com voted on patch set 2 V +1 04/25/18, 14:25 Completed build in 09m 19s on Wed, 25 Apr, 04:25 PM Test Summary: 31061 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-22898

  6. Daniel Gorges voted on patch set 2 V +1 CR +1 04/26/18, 04:49

  7. Georg Ringer commented on patch set 2 04/26/18, 05:26

    DatabaseRecordList.php:3967

    didn't we use the ->get method directly instead of checking with has and then with get? ... or is this for runtime caches ok?
  8. Benni Mack commented on patch set 2 04/26/18, 05:37

    DatabaseRecordList.php:3967 Reply

    fine for runtime checks here, I'd say.
  9. Georg Ringer voted on patch set 2 V +2 CR +2 04/26/18, 05:41

  10. Georg Ringer merged patch set 3 04/26/18, 05:41

  11. Benni Mack commented on patch set 3 04/26/18, 06:06

    great. just checked - no backport needed - this was removed in 9.0 but already built the same way in v8!