Review main Merged

56806[BUGFIX] Unknown OS icon instead of windows as fallback

Jan Stockfisch CR +2 V +2 Easy +9 −6 updated 06/23/18, 00:53

Commit message

Review

  • Code review CR +2
    • Benjamin Kott +2
    • Tobi Kretschmann +1
  • Verified V +2
    • Benjamin Kott +2
    • Tobi Kretschmann +1
    • TYPO3com +1 CI

Issues 1

Files 2

Review log 1015

  1. Jan Stockfisch uploaded patch set 1 04/25/18, 14:41

  2. TYPO3com voted on patch set 1 V +1 04/25/18, 14:51 Completed build in 09m 49s on Wed, 25 Apr, 04:51 PM Test Summary: 31061 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-22901

  3. Stephan Großberndt commented on patch set 2 04/25/18, 17:15

    Published edit on patch set 1.
  4. TYPO3com voted on patch set 2 V +1 04/25/18, 17:24 Completed build in 09m 22s on Wed, 25 Apr, 07:24 PM Test Summary: 31061 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-22916

  5. Jan Stockfisch commented on patch set 2 V -1 CR -1 04/26/18, 08:59

    This cannot be backport to php <7.2. The predefined `PHP_OS_FAMILY` constant was introduced in php7.2.
  6. Jan Stockfisch updated the commit message in patch set 3 04/26/18, 09:01

  7. TYPO3com voted on patch set 3 V +1 04/26/18, 09:09 Completed build in 08m 15s on Thu, 26 Apr, 11:09 AM Test Summary: 31061 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-22935

  8. Jürgen Venne uploaded patch set 4 06/22/18, 23:55

  9. Tobi Kretschmann updated the commit message in patch set 5 06/23/18, 00:01

  10. Tobi Kretschmann voted on patch set 5 V +1 CR +1 06/23/18, 00:01

  11. Jürgen Venne voted on patch set 4 V +1 CR +1 06/23/18, 00:02

  12. TYPO3com voted on patch set 4 V +1 06/23/18, 00:06 Completed build in 11m 27s on Sat, 23 Jun, 02:06 AM Test Summary: 32723 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-24733

  13. TYPO3com voted on patch set 5 V +1 06/23/18, 00:09 Completed build in 08m 35s on Sat, 23 Jun, 02:09 AM Test Summary: 32723 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-24734

  14. Benjamin Kott voted on patch set 5 V +2 CR +2 06/23/18, 00:53

  15. Benjamin Kott merged patch set 6 06/23/18, 00:53