Review TYPO3_8-7 Abandoned

56807[WIP][BUGFIX] Don't use windows OS icon as default

Jan Stockfisch CR 0 V 0 Easy +6 −1 updated 04/30/18, 06:49

Commit message

Review

  • Code review CR 0
  • Verified V 0

Issues 1

Files 1

Review log 1216

  1. Jan Stockfisch uploaded patch set 1 04/25/18, 15:02

  2. Jan Stockfisch updated the commit message in patch set 2 04/25/18, 15:03

  3. TYPO3com voted on patch set 1 V +1 04/25/18, 15:16 Completed build in 13m 44s on Wed, 25 Apr, 05:16 PM Test Summary: 58383 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC87-2348

  4. TYPO3com voted on patch set 2 V +1 04/25/18, 15:17 Completed build in 14m 08s on Wed, 25 Apr, 05:17 PM Test Summary: 58383 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC87-2349

  5. Stephan Großberndt commented on patch set 2 CR -1 04/25/18, 16:58

    Please abandon this backport with a different change id as the original. Backports are done when the master change has been merged in most cases.
  6. Stephan Großberndt commented on patch set 2 04/25/18, 17:09

    As the code will differ for 8.7, its ok to have a backport in review at the same time but it must have the same change id. Backport to 7.6 will not be done as only security or major bugs are fixed in that branch
  7. Oliver Klee updated the commit message in patch set 3 04/25/18, 17:18

  8. TYPO3com voted on patch set 3 V +1 04/25/18, 17:28 Completed build in 09m 39s on Wed, 25 Apr, 07:28 PM Test Summary: 58383 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC87-2350

  9. Jan Stockfisch updated the commit message in patch set 4 04/26/18, 08:55

  10. Jan Stockfisch commented on patch set 4 04/26/18, 08:56

    Why does the backport MUST have a different change-ID? The change for master is completely different and cannot be backported.
  11. TYPO3com voted on patch set 4 V +1 04/26/18, 09:08 Completed build in 13m 32s on Thu, 26 Apr, 11:08 AM Test Summary: 58383 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC87-2353

  12. Jan Stockfisch commented on patch set 4 04/26/18, 12:48

    > Why does the backport MUST have a different change-ID? The change > for master is completely different and cannot be backported. I mean same change-id of of course.
  13. Susi Moog commented on patch set 4 04/29/18, 14:29

    the backport should have the same change ID to group both patches together. while the implementation differs, the bug exists in both cases and both patches belong together. whilst not strictly a backport in the original sense it is a backport in an abstract sense "this is a fix for 8.7 for an issue already fixed in master".
  14. Susi Moog commented on patch set 4 CR -2 04/29/18, 14:30

    [oh and as gerrit can't handle updated change-ids in the same patch set as it's the unique identifier please push a complete new change with the new change ID - thanks]
  15. Jan Stockfisch commented on patch set 4 04/30/18, 06:49

    Fair enough. Will push the patch again as soon as the patch for master has been cherrypicked.
  16. Jan Stockfisch abandoned the change 04/30/18, 06:49