Review main Merged

56808[BUGFIX] Only show default language pages for sorting

Benni Mack CR +2 V +2 Easy +1 −0 updated 04/25/18, 21:32

Commit message

The sorting of subpages also shows all translations
which leads to very bad side-effects due to the removal
of pages_language_overlay. This case wasn't fixed yet.

The query for fetching all subpages is now adapted to
only fetch pages with sys_language_uid=0.

Review

  • Code review CR +2
    • Georg Ringer +2
    • Wouter Wolters +1
    • Andreas Kienast +1
  • Verified V +2
    • Georg Ringer +2
    • Andreas Kienast +1
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 67

  1. Benni Mack uploaded patch set 1 04/25/18, 15:32

  2. TYPO3com voted on patch set 1 V +1 04/25/18, 15:41 Completed build in 08m 15s on Wed, 25 Apr, 05:41 PM Test Summary: 31061 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-22904

  3. Wouter Wolters voted on patch set 1 CR +1 04/25/18, 16:52

  4. Andreas Kienast voted on patch set 1 CR +1 04/25/18, 16:57

  5. Andreas Kienast voted on patch set 1 V +1 04/25/18, 19:25

  6. Georg Ringer voted on patch set 1 V +2 CR +2 04/25/18, 21:32

  7. Georg Ringer merged patch set 2 04/25/18, 21:32