Review main Merged

5681[BUGFIX] Showmodule cannot be called before Store is loaded

Kay Strobach CR +2 V +2 Easy +20 −1 updated 06/03/13, 20:49

Commit message

Example: Using the direct page edit feature (backend.php?edit=xxx)
the BE responds with "Module loader No module found. If this is a
temporary error, please reload the Backend!" error.

Since the AJAX request is not finished at the time this is called,
it has to be checked whether the store was completely loaded.

Review

  • Code review CR +2
    • Xavier Perseguers +2
    • Helmut Hummel +1
  • Verified V +2
    • Jigal van Hemert +2
    • Xavier Perseguers +1

Issues 1

Files 1

Review log 17

  1. Xavier Perseguers commented on patch set 1 10/11/11, 08:21

    Verified; Looks good to me, but someone else must approve
    Invalid bug id
  2. Xavier Perseguers commented on patch set 1 10/11/11, 08:21

    No score Actually the error is removed but the edit form is not shown
  3. Xavier Perseguers commented on patch set 1 1 comment 10/11/11, 08:21

    No score
  4. Oliver Hader uploaded patch set 3 10/11/11, 08:21

  5. Oliver Hader commented on patch set 3 10/11/11, 08:21

    I've added another patch that adds a flag on the store to indicate whether it was loaded. The DelayedTask could be used as well here (since it prevents multiple calls to the same method) however uses setTimeout() as well.
  6. Oliver Hader uploaded patch set 4 10/11/11, 08:21

  7. Xavier Perseguers commented on patch set 4 10/11/11, 08:21

    Verified; Looks good to me, approved
  8. Helmut Hummel commented on patch set 2 10/11/11, 08:21

    Do not submit Please do not misuse the commit message by adding personal messages to it.
  9. Helmut Hummel commented on patch set 4 10/11/11, 08:21

    Looks good to me, but someone else must approve
  10. Kay Strobach uploaded patch set 2 10/11/11, 08:21

  11. Kay Strobach commented on patch set 4 10/11/11, 08:21

    that hides the error message - for sure, but makes the parameter edit = xx uselses, a combination of patchset 2 and 4 should do the trick!
  12. Jigal van Hemert commented on patch set 4 V 0 10/11/11, 08:21

    by team member Problem with timing is solved; making edit=xxx working will go in new change.
  13. Mr. Jenkins commented on patch set 1 10/11/11, 08:21

  14. Mr. Jenkins commented on patch set 2 10/11/11, 08:21

  15. Mr. Jenkins commented on patch set 3 10/11/11, 08:21

  16. Mr. Jenkins commented on patch set 4 10/11/11, 08:21

  17. Jigal van Hemert merged patch set 4 10/11/11, 08:21