Review main Merged

56811[TASK] Use "assets" cache for t3editor configuration

Andreas Kienast CR +2 V +2 Easy +5 −5 updated 05/02/18, 05:31

Commit message

The t3editor cache is now stored in the `assets` cache, as `cache_core`
is discouraged for extensions.
As the cache only needs to store JavaScript-based configuration, this is
also a more appropriate cache.

Review

  • Code review CR +2
    • Jigal van Hemert +2
    • Wouter Wolters +1
    • Markus Klein +1
  • Verified V +2
    • Jigal van Hemert +2
    • Markus Klein +1
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 1720

  1. Andreas Kienast uploaded patch set 1 04/25/18, 16:28

  2. TYPO3com voted on patch set 1 V +1 04/25/18, 16:39 Completed build in 11m 08s on Wed, 25 Apr, 06:39 PM Test Summary: 31061 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-22913

  3. Wouter Wolters voted on patch set 1 CR +1 04/25/18, 16:52

  4. Markus Klein commented on patch set 1 04/25/18, 19:32

    T3editor.php:133

    wouldn't it be even better to use a different cache where we can store the variable directly?
  5. Andreas Kienast commented on patch set 1 04/26/18, 05:53

    T3editor.php:133 Reply

    What do you mean with "different cache"? FileBackend cache is used on purpose here.
  6. Markus Klein commented on patch set 1 04/26/18, 08:19

    You use the cache_core cache here, which uses the \TYPO3\CMS\Core\Cache\Frontend\PhpFrontend::class I would rather go for a cache that uses \TYPO3\CMS\Core\Cache\Frontend\VariableFrontend::class eg 'assets'
  7. Jigal van Hemert commented on patch set 1 V +1 CR +1 04/26/18, 10:39

    > You use the cache_core cache here, which uses the \TYPO3\CMS\Core\Cache\Frontend\PhpFrontend::class > > I would rather go for a cache that uses \TYPO3\CMS\Core\Cache\Frontend\VariableFrontend::class > eg 'assets' The `VariableFrontend` uses `serialize()` to store the variable information. I don't think that is an improvement.
  8. Markus Klein commented on patch set 1 04/26/18, 11:51

    Better than json_* And definitely cleaner than generating PHP code with var_export.
  9. Markus Klein commented on patch set 1 CR -1 04/26/18, 11:52

    soft -1 until Andy can react on my comments
  10. Andreas Kienast commented on patch set 1 04/26/18, 11:55

    Hm, I dislike having serialize here. If I change the code to use serialize, then we should change *any* usage of var_export to serialize.
  11. Markus Klein commented on patch set 1 04/26/18, 12:39

    My point is: Why to employ custom code to store stuff in the cache? The cache can already do that for us, that's its job.
  12. Markus Klein commented on patch set 1 CR 0 04/26/18, 13:31

    Discussed my points with Andy in Slack and I remove my -1 here to let him freely decide
  13. Andreas Kienast uploaded patch set 2 05/01/18, 07:11

  14. TYPO3com voted on patch set 2 V +1 05/01/18, 07:21 Completed build in 09m 40s on Tue, 1 May, 09:21 AM Test Summary: 31061 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-23002

  15. Markus Klein updated the commit message in patch set 3 05/01/18, 08:30

  16. TYPO3com voted on patch set 3 V +1 05/01/18, 08:38 Completed build in 07m 46s on Tue, 1 May, 10:38 AM Test Summary: 31061 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-23005

  17. Markus Klein voted on patch set 3 V +1 CR +1 05/01/18, 08:43

  18. Wouter Wolters voted on patch set 3 CR +1 05/01/18, 08:45

  19. Jigal van Hemert voted on patch set 3 V +2 CR +2 05/02/18, 05:31

  20. Jigal van Hemert merged patch set 4 05/02/18, 05:31