Review main Merged Breaking

56813[!!!][TASK] Make localization wizard independent of colPos

Andreas Kienast CR +2 V +2 Hard +536 −437 updated 07/24/18, 13:36

Commit message

The localization wizard in the page module offers now a global translate
action per page only. With this change, a user isn't anymore able to
translate content on column basis.

This streamlines the localization process as it lowers the risk of
creating broken localization setups (a.k.a "mixed mode") and it will
simplify the upcoming "Change mode" wizard that enables to switch
between "Free" and "Connected" modes.

Review

  • Code review CR +2
    • Mathias Brodala +2
    • Christian Kuhn +1
  • Verified V +2
    • Mathias Brodala +2
    • Christian Kuhn +1
    • TYPO3com +1 CI

Issues 1

Files 24

Show 4 more files

Review log 4770

Show 2845 earlier messages
  1. Andreas Kienast uploaded patch set 1 04/25/18, 17:40

  2. TYPO3com voted on patch set 1 V -1 04/25/18, 17:40 Completed build in 11s on Wed, 25 Apr, 07:40 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-22918

  3. Andreas Kienast uploaded patch set 2 04/25/18, 19:21

  4. TYPO3com voted on patch set 2 V -1 04/25/18, 19:31 Completed build in 09m 33s on Wed, 25 Apr, 09:31 PM Test Summary: 30 of 31213 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-22924

  5. Andreas Kienast uploaded patch set 3 04/26/18, 07:55

  6. TYPO3com voted on patch set 3 V -1 04/26/18, 08:04 Completed build in 08m 24s on Thu, 26 Apr, 10:04 AM Test Summary: 10 of 31213 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-22934

  7. Andreas Kienast uploaded patch set 4 04/26/18, 13:34

  8. TYPO3com voted on patch set 4 V -1 04/26/18, 13:44 Completed build in 09m 11s on Thu, 26 Apr, 03:44 PM Test Summary: 6 of 31213 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-22937

  9. Andreas Kienast uploaded patch set 5 04/26/18, 14:39

  10. TYPO3com voted on patch set 5 V +1 04/26/18, 14:48 Completed build in 08m 49s on Thu, 26 Apr, 04:48 PM Test Summary: 31061 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-22939

  11. Andreas Kienast uploaded patch set 6 05/01/18, 07:39

  12. Andreas Kienast uploaded patch set 7 05/01/18, 07:41

  13. TYPO3com voted on patch set 6 V -1 05/01/18, 07:49 Completed build in 09m 40s on Tue, 1 May, 09:49 AM Test Summary: 1 of 31213 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-23003

  14. TYPO3com voted on patch set 7 V +1 05/01/18, 07:52 Completed build in 10m 34s on Tue, 1 May, 09:52 AM Test Summary: 31061 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-23004

  15. Andreas Kienast uploaded patch set 8 05/02/18, 18:01

  16. TYPO3com voted on patch set 8 V +1 05/02/18, 18:11 Completed build in 10m 01s on Wed, 2 May, 08:11 PM Test Summary: 31061 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-23014

  17. Riccardo De Contardi commented on patch set 8 05/05/18, 17:26

    even if I have unselected one of the columns to translate on the wizard, it has been translated nonetheless. It happens with both translate and copy mode.
  18. Andreas Kienast commented on patch set 8 V -1 05/05/18, 18:33

    Will update the patch
  19. Andreas Kienast uploaded patch set 9 05/05/18, 18:39

  20. TYPO3com voted on patch set 9 V +1 05/05/18, 18:48 Completed build in 09m 26s on Sat, 5 May, 08:48 PM Test Summary: 31154 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-23074

  21. Andreas Kienast uploaded patch set 10 05/08/18, 11:48

  22. TYPO3com voted on patch set 10 V -1 05/08/18, 11:49 Completed build in 06s on Tue, 8 May, 01:49 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-23148

  23. Andreas Kienast uploaded patch set 11 05/08/18, 11:51

  24. TYPO3com voted on patch set 11 V +1 05/08/18, 12:00 Completed build in 08m 16s on Tue, 8 May, 02:00 PM Test Summary: 30991 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-23149

  25. Frank Nägler commented on patch set 11 CR -1 05/08/18, 13:04

    LocalizationRepository.php:79

    what about return an empty array as fallback instead of null?

    AjaxRoutes.php:250

    change the route name is possible breaking, this should be mentioned in the rst file or maybe better in an own rst file?

    LocalizationControllerTest.php:109

    maybe add another test case with colPos not set?

    LocalizationControllerTest.php:171

    here too
  26. Andreas Kienast commented on patch set 11 05/08/18, 13:46

    LocalizationRepository.php:79 Reply

    I don't have a strong opinion here

    AjaxRoutes.php:250 Reply

    I agree this is breaking, but I don't see why someone would call that route in a 3rd party extension. Better be safe than sorry, a new ReST file should be created.

    LocalizationControllerTest.php:109 Reply

    Interesting :)
  27. Andreas Kienast uploaded patch set 12 05/08/18, 14:29

  28. Andreas Kienast commented on patch set 12 05/08/18, 14:29

    Will refactor the tests with this patch to get them more readable
  29. TYPO3com voted on patch set 12 V +1 05/08/18, 14:38 Completed build in 08m 35s on Tue, 8 May, 04:38 PM Test Summary: 30991 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-23156

  30. Andreas Kienast uploaded patch set 13 05/09/18, 07:08

  31. TYPO3com voted on patch set 13 V +1 05/09/18, 07:19 Completed build in 10m 59s on Wed, 9 May, 09:19 AM Test Summary: 31058 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-23216

  32. Andreas Kienast uploaded patch set 14 05/10/18, 17:52

  33. TYPO3com voted on patch set 14 V +1 05/10/18, 18:04 Completed build in 11m 15s on Thu, 10 May, 08:04 PM Test Summary: 31003 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-23284

  34. Georg Ringer commented on patch set 14 05/10/18, 18:53

    LocalizationRepository.php:40

    all those usages could be found by code checker in Install Tool, having 3 aguments. wanna add it? same below
  35. Andreas Kienast uploaded patch set 15 05/10/18, 19:10

  36. TYPO3com voted on patch set 15 V +1 05/10/18, 19:19 Completed build in 08m 04s on Thu, 10 May, 09:19 PM Test Summary: 31003 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-23291

  37. Andreas Kienast uploaded patch set 16 05/11/18, 04:37

  38. TYPO3com voted on patch set 16 V +1 05/11/18, 04:45 Completed build in 08m 17s on Fri, 11 May, 06:45 AM Test Summary: 31003 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-23303

  39. Andreas Kienast uploaded patch set 17 05/14/18, 08:55

  40. TYPO3com voted on patch set 17 V +1 05/14/18, 09:06 Completed build in 10m 38s on Mon, 14 May, 11:06 AM Test Summary: 31180 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-23472

  41. Mathias Brodala commented on patch set 17 05/14/18, 13:48

    LocalizationRepository.php:37

    Can we keep this parameter but leave it unused? We could properly deprecate and remove it with v10 then.

    AjaxRoutes.php:250

    I think "page_languages" better describes what the route does.
  42. Andreas Kienast commented on patch set 17 05/14/18, 14:03

    LocalizationRepository.php:37 Reply

    Probably, I have no strong opinion here.

    AjaxRoutes.php:250 Reply

    Visited by Yoda I was. Sure, makes sense.
  43. Andreas Kienast commented on patch set 17 05/14/18, 14:20

    LocalizationRepository.php:37 Reply

    After having a chat with Mathias, we will skip any deprecation here. Otherwise, userland code needs to get touched twice (1. fixing the deprecation, 2. when the actual breaking change kicks in).
  44. Andreas Kienast uploaded patch set 18 05/14/18, 14:22

  45. Andreas Kienast uploaded patch set 19 05/14/18, 14:29

  1. TYPO3com voted on patch set 18 V +1 05/14/18, 14:30 Completed build in 07m 25s on Mon, 14 May, 04:30 PM Test Summary: 31184 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-23485

  2. TYPO3com voted on patch set 19 V +1 05/14/18, 14:38 Completed build in 09m 02s on Mon, 14 May, 04:38 PM Test Summary: 31184 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-23486

  3. Mona Muzaffar voted on patch set 19 V +1 05/14/18, 19:31

  4. Mathias Brodala commented on patch set 19 05/15/18, 07:42

    PageLayoutView.php:2457

    Can we also add a label to this button? It's very tiny and I almost missed it. Simply dropping the title attribute and moving the label after the icon already helps.
  5. Andreas Kienast commented on patch set 19 05/15/18, 09:42

    PageLayoutView.php:2457 Reply

    We need a proper concept here, as more buttons are planned, e.g. for the connected/free wizard.
  6. Mathias Brodala commented on patch set 19 05/15/18, 09:53

    PageLayoutView.php:2457 Reply

    I get that but for now we really need the button label since until now the buttons also had a label and that's the first thing people will look for. Do you think the wizard will get in before the next sprint release?
  7. Andreas Kienast commented on patch set 19 05/15/18, 10:28

    > Patch Set 19: > > (1 comment) Will add the label, the wizard will make it in 9.4.
  8. Andreas Kienast rebased onto patch set 20 05/15/18, 12:08

  9. Andreas Kienast uploaded patch set 21 05/15/18, 12:10

  10. TYPO3com voted on patch set 20 V +1 05/15/18, 12:18 Completed build in 09m 25s on Tue, 15 May, 02:18 PM Test Summary: 31187 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-23507

  11. TYPO3com voted on patch set 21 V +1 05/15/18, 12:19 Completed build in 09m 28s on Tue, 15 May, 02:19 PM Test Summary: 31187 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-23508

  12. Mathias Brodala voted on patch set 21 V +1 CR +1 05/15/18, 12:38

  13. Markus Klein commented on patch set 21 05/15/18, 13:03

    LocalizationController.php:38

    shouldn't it be part of the breaking docs that this is internal now

    LocalizationController.php:75

    this rename isn't documented
  14. Andreas Kienast uploaded patch set 22 05/15/18, 13:53

  15. Mathias Brodala voted on patch set 22 V +1 CR +1 05/15/18, 13:59

  16. TYPO3com voted on patch set 22 V +1 05/15/18, 14:02 Completed build in 09m 38s on Tue, 15 May, 04:02 PM Test Summary: 31187 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-23516

  17. Markus Klein voted on patch set 22 CR +1 05/15/18, 15:44

  18. Markus Klein uploaded patch set 23 05/16/18, 10:00

  19. TYPO3com voted on patch set 23 V +1 05/16/18, 10:08 Completed build in 07m 44s on Wed, 16 May, 12:08 PM Test Summary: 31159 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-23528

  20. Andreas Kienast commented on patch set 23 05/16/18, 10:38

    Thanks Markus!
  21. Mathias Brodala voted on patch set 23 V +1 CR +1 05/16/18, 14:40

  22. Christian Kuhn commented on patch set 23 V +1 CR +1 05/17/18, 07:44

    ok. the only not-too-great thing are the breakings which we want to reduce as much as possible in non .0 releases. There would have been options - for instance keeping the old route (adding an @deprecated in front, then trigger_error() in the method and use a new one). However, since that has been discussed already and decided against, I don't want to open that once again and stick to the decision that has been taken. If we really want to relax the breakings again, that could be done later if the majority wants to go for it. Testing looks good, the wizard seems to work, the button appears when i expect it, colPos settings and sorting seem to be ok. If there are issues, they are more hidden.
  23. Mathias Brodala voted on patch set 23 V +2 CR +2 05/17/18, 07:48

  24. Mathias Brodala merged patch set 24 05/17/18, 07:48

  25. Tymoteusz Motylewski commented on patch set 24 07/24/18, 13:36

    CreatedElementOrdering.csv:10

    shouldn't the sorting of this record be between 1152 and 1216? Now the record sorting is 1, 2.5, 2, 3 instead of 1, 2, 2.5, 3