Review main Merged

56819[TASK] Replace PATH_thisScript with Environment API call

Benni Mack CR +2 V +2 Easy +11 −9 updated 04/27/18, 19:40

Commit message

All occurrences in the TYPO3 core have been replaced with
Environment::getCurrentScript() in order to slowly migrate
away from constants, and also detect dependencies to Environment
related functionality easier.

Review

  • Code review CR +2
    • Tymoteusz Motylewski +2
    • Georg Ringer +1
  • Verified V +2
    • Tymoteusz Motylewski +2
    • Georg Ringer +1
    • TYPO3com +1 CI

Issues 1

Files 5

Review log 45

  1. Benni Mack uploaded patch set 1 04/26/18, 16:48

  2. TYPO3com voted on patch set 1 V +1 04/26/18, 16:57 Completed build in 09m 20s on Thu, 26 Apr, 06:57 PM Test Summary: 31061 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-22950

  3. Georg Ringer voted on patch set 1 V +1 CR +1 04/27/18, 15:44

  4. Tymoteusz Motylewski voted on patch set 1 V +2 CR +2 04/27/18, 19:39

  5. Tymoteusz Motylewski merged patch set 2 04/27/18, 19:40