Review main Merged

56821[BUGFIX] Show thumbnail in list module for columns in palettes

David Gurk CR +2 V +2 Hard +262 −1 updated 07/31/18, 12:26

Commit message

By replacing the palettes in showitem of types with their content,
the following condition can consider the columns within the palettes.

Review

  • Code review CR +2
    • Markus Klein +2
    • Fabien Udriot +1
    • Jörg Bösche +1
  • Verified V +2
    • Markus Klein +2
    • Fabien Udriot +1
    • TYPO3com +1 CI

Issues 2

Files 2

Review log 5775

Show 3650 earlier messages
  1. David Gurk uploaded patch set 1 04/27/18, 14:39

  2. TYPO3com voted on patch set 1 V +1 04/27/18, 14:49 Completed build in 09m 48s on Fri, 27 Apr, 04:49 PM Test Summary: 31061 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-22969

  3. David Gurk updated the commit message in patch set 2 04/27/18, 15:03

  4. TYPO3com voted on patch set 2 V +1 04/27/18, 15:13 Completed build in 09m 14s on Fri, 27 Apr, 05:13 PM Test Summary: 31061 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-22970

  5. Fabien Udriot commented on patch set 2 CR -1 05/01/18, 12:47

    DatabaseRecordList.php:1459

    I would add a check that 'palettes' is really an array. We have no guarantee about that.
  6. David Gurk uploaded patch set 3 05/02/18, 07:17

  7. David Gurk commented on patch set 3 05/02/18, 07:20

    I have checked it in the core and found a similar rule in BackendUtility. I have added the condition.
  8. TYPO3com voted on patch set 3 V +1 05/02/18, 07:27 Completed build in 09m 57s on Wed, 2 May, 09:27 AM Test Summary: 31061 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-23009

  9. Fabien Udriot voted on patch set 3 CR +1 05/02/18, 07:44

  10. Mathias Schreiber voted on patch set 3 V +1 CR +1 05/10/18, 14:56

  11. Roberto Torresani voted on patch set 3 V +1 CR +1 05/11/18, 14:13

  12. Cristian Buja commented on patch set 3 V +1 CR -1 05/11/18, 14:48

    DatabaseRecordList.php:1464

    I tested the patch: it works only if there's no spaces between fields in the declaration. Example, it doesn't work if 'showitem' => ' , fal_media ,' So, please, give the possibility to insert spaces between values
  13. Cristian Buja uploaded patch set 4 05/11/18, 15:27

  14. TYPO3com voted on patch set 4 V -1 05/11/18, 15:27 Completed build in 10s on Fri, 11 May, 05:27 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-23334

  15. Cristian Buja uploaded patch set 5 05/11/18, 15:29

  16. TYPO3com voted on patch set 5 V +1 05/11/18, 15:37 Completed build in 07m 44s on Fri, 11 May, 05:37 PM Test Summary: 31003 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-23335

  17. David Gurk voted on patch set 5 CR +1 05/11/18, 19:21

  18. Fabien Udriot voted on patch set 5 CR +1 05/12/18, 05:03

  19. Alessandro Filira voted on patch set 5 CR +1 05/12/18, 08:29

  20. Elena Bartolotti voted on patch set 5 V +1 05/12/18, 10:06

  21. Mathias Schreiber uploaded patch set 6 05/12/18, 13:53

  22. TYPO3com voted on patch set 6 V -1 05/12/18, 13:53 Completed build in 06s on Sat, 12 May, 03:53 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-23369

  23. Mathias Schreiber commented on patch set 6 05/12/18, 13:54

    I brought in a unittest that shows that the regex needs a bit more love. Unfortunately I'm too stupid for regex, so maybe someone else can jump in?
  24. Mathias Schreiber uploaded patch set 7 05/12/18, 13:55

  25. TYPO3com voted on patch set 7 V -1 05/12/18, 14:02 Completed build in 07m 23s on Sat, 12 May, 04:02 PM Test Summary: 6 of 31376 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-23370

  26. David Gurk uploaded patch set 8 05/12/18, 18:55

  27. TYPO3com voted on patch set 8 V -1 05/12/18, 18:55 Completed build in 07s on Sat, 12 May, 08:55 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-23393

  28. David Gurk uploaded patch set 9 05/12/18, 18:57

  29. David Gurk commented on patch set 9 05/12/18, 19:01

    I updated both regex. Add a $ to the first and update whitespace-handling in the second.
  30. TYPO3com voted on patch set 9 V +1 05/12/18, 19:05 Completed build in 08m 28s on Sat, 12 May, 09:05 PM Test Summary: 31129 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-23394

  31. David Gurk uploaded patch set 10 05/12/18, 21:00

  32. TYPO3com voted on patch set 10 V -1 05/12/18, 21:00 Completed build in 07s on Sat, 12 May, 11:00 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-23398

  33. David Gurk uploaded patch set 11 05/12/18, 21:01

  34. David Gurk commented on patch set 11 05/12/18, 21:04

    I merged the logic from the preg_replace for whitespace cleaning with the rtrim call.
  35. TYPO3com voted on patch set 11 V +1 05/12/18, 21:09 Completed build in 08m 26s on Sat, 12 May, 11:09 PM Test Summary: 31129 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-23399

  36. David Gurk commented on patch set 11 05/13/18, 13:35

    Does anyone know if rtrim is faster/slower than the preg_replace(/[\s\t\r\n]+$/) solution? I don't know something like jsperf.com for PHP.
  37. Mathias Schreiber voted on patch set 11 V +1 CR +1 05/14/18, 07:20

  38. Cristian Buja voted on patch set 11 V +1 CR +1 05/15/18, 05:45

  39. Cristian Buja commented on patch set 11 05/15/18, 05:50

    About performance i don't test, but in this collection rtrim is the winner: http://maettig.com/code/php/php-performance-benchmarks.php
  40. Alexander Opitz commented on patch set 11 05/15/18, 16:52

    Hmmm, maybe we can do this more clean, especially the preg_match parts which have all this matching on ";" (not only in the new code, also in the existing code). For example, take a look at TYPO3\CMS\Backend\Form\FormDataProvider\TcaColumnsProcessShowitem::addData So I'm unsure on this patch set, maybe ask Lolli on this. BTW: There are too much parts which implement extracting "field Configuration", we should use an API for that.
  41. David Gurk commented on patch set 11 05/23/18, 09:58

    Are there other opinions? I think of the preg_match on ";" as the only solution, currently. Maybe an API is more a long term solution.
  42. Nicole Hummel commented on patch set 11 CR -1 05/23/18, 12:11

    DatabaseRecordListTest.php:3

    needs to be removed

    DatabaseRecordListTest.php:18

    needs to be moved to top

    DatabaseRecordListTest.php:38

    please move data provider before the actual test
  43. Nicole Hummel uploaded patch set 12 05/23/18, 12:31

  44. Nicole Hummel commented on patch set 12 05/23/18, 12:32

    DatabaseRecordList.php:4417

    I think it is better to only process available palettes instead of iterating over all palettes
  45. TYPO3com voted on patch set 12 V -1 05/23/18, 12:38 Completed build in 06m 56s on Wed, 23 May, 02:38 PM Test Summary: 3 of 31357 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-23730

  46. Nicole Hummel uploaded patch set 13 05/23/18, 12:44

  47. Nicole Hummel uploaded patch set 14 05/23/18, 12:48

  48. TYPO3com voted on patch set 13 V -1 05/23/18, 12:52 Completed build in 07m 36s on Wed, 23 May, 02:52 PM Test Summary: 3 of 31357 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-23731

  49. TYPO3com voted on patch set 14 V +1 05/23/18, 12:55 Completed build in 06m 55s on Wed, 23 May, 02:55 PM Test Summary: 31110 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-23732

  50. Alexander Opitz commented on patch set 14 V +1 CR +1 05/28/18, 14:11

    Not perfect, but better. Thx
  1. Tymoteusz Motylewski commented on patch set 14 05/28/18, 14:20

    DatabaseRecordList.php:4406

    please add some description explaining what the function does
  2. Tymoteusz Motylewski voted on patch set 14 CR -1 05/30/18, 19:17

  3. David Gurk uploaded patch set 15 07/07/18, 15:55

  4. David Gurk commented on patch set 15 07/07/18, 15:56

    Is the new description fine?
  5. TYPO3com voted on patch set 15 V +1 07/07/18, 16:03 Completed build in 07m 34s on Sat, 7 Jul, 06:03 PM Test Summary: 32898 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-25212

  6. Alexander Opitz voted on patch set 15 V +1 CR +1 07/14/18, 16:56

  7. Markus Klein commented on patch set 15 07/14/18, 21:12

    DatabaseRecordList.php:4427

    why a character class?
  8. David Gurk uploaded patch set 16 07/16/18, 07:57

  9. TYPO3com voted on patch set 16 V +1 07/16/18, 08:05 Completed build in 07m 41s on Mon, 16 Jul, 10:05 AM Test Summary: 33327 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-25454

  10. Jörg Bösche voted on patch set 16 CR +1 07/16/18, 08:08

  11. Markus Klein voted on patch set 16 CR +1 07/16/18, 16:29

  12. David Gurk commented on patch set 16 07/17/18, 06:50

    As far as I can see, it does not interfere with #82826.

    DatabaseRecordList.php:4427 Reply

    Acknowledged and updated.
  13. Markus Klein commented on patch set 16 CR 0 07/17/18, 17:03

    DatabaseRecordListTest.php:114

    Please add a test where we hava trailing comma here
  14. David Gurk uploaded patch set 17 07/19/18, 09:15

  15. David Gurk commented on patch set 17 07/19/18, 09:21

    I found a weird bug while testing 'trailingLinebreakInPalette'. In that case the custom rtrim() doesn't remove the trailing linebreak. Normally it should, because we added the characters from the default $character_mask (http://php.net/manual/en/function.rtrim.php). The only solution I see, is to use two rtrim. One with default and one with explicit trim for comma. Look at this sandbox for insights: http://sandbox.onlinephpfunctions.com/code/a8bc1c70cd05c972c86a04e7da2b2388d25edca3 Alternative solutions are welcome.
  16. TYPO3com voted on patch set 17 V +1 07/19/18, 09:23 Completed build in 07m 18s on Thu, 19 Jul, 11:23 AM Test Summary: 33402 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-25544

  17. Markus Klein commented on patch set 17 CR -1 07/19/18, 14:58

    DatabaseRecordList.php:4431

    The problem is you are using a single quoted string here. overlooked that too. ", \t\r\n" will work
  18. Markus Klein commented on patch set 18 07/19/18, 15:01

    Published edit on patch set 17.
  19. Markus Klein voted on patch set 18 CR +1 07/19/18, 15:01

  20. TYPO3com voted on patch set 18 V +1 07/19/18, 15:08 Completed build in 07m 21s on Thu, 19 Jul, 05:08 PM Test Summary: 33402 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-25556

  21. David Gurk commented on patch set 18 07/20/18, 06:29

    Thank you for the solution. This was a subtile change. =)
  22. Jörg Bösche voted on patch set 18 CR +1 07/31/18, 08:56

  23. Fabien Udriot voted on patch set 18 V +1 CR +1 07/31/18, 09:17

  24. Markus Klein voted on patch set 18 V +2 CR +2 07/31/18, 12:26

  25. Markus Klein merged patch set 19 07/31/18, 12:26