Review main Merged

56823[BUGFIX] Prevent re-initialization of logger in SignalSlot Dispatcher

Nicole Hummel CR +2 V +2 Normal +40 −12 updated 04/29/18, 20:11

Commit message

Review

  • Code review CR +2
    • Georg Ringer +2
    • Susi Moog +1
    • Helmut Hummel +1
  • Verified V +2
    • Georg Ringer +2
    • Helmut Hummel +1
    • TYPO3com +1 CI

Issues 1

Files 2

Review log 1216

  1. Nicole Hummel uploaded patch set 1 04/28/18, 06:35

  2. TYPO3com voted on patch set 1 V +1 04/28/18, 06:44 Completed build in 08m 16s on Sat, 28 Apr, 08:44 AM Test Summary: 31061 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-22976

  3. Susi Moog commented on patch set 1 V -1 04/29/18, 09:42

    Have to debug what happens, but the feature in adminPanel based on the log entries is broken now.
  4. Susi Moog commented on patch set 1 V 0 04/29/18, 10:03

    ... I think I fixed it on my site ;)
  5. Susi Moog updated the commit message in patch set 2 04/29/18, 12:02

  6. TYPO3com voted on patch set 2 V +1 04/29/18, 12:10 Completed build in 08m 14s on Sun, 29 Apr, 02:10 PM Test Summary: 31061 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-22982

  7. Susi Moog voted on patch set 2 V +1 CR +1 04/29/18, 14:24

  8. Nicole Hummel uploaded patch set 3 04/29/18, 15:22

  9. Nicole Hummel commented on patch set 3 04/29/18, 15:23

    I stream lined the logger call to other places inside the core
  10. TYPO3com voted on patch set 3 V -1 04/29/18, 15:30 Completed build in 08m 17s on Sun, 29 Apr, 05:30 PM Test Summary: 30 of 31213 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-22986

  11. Nicole Hummel uploaded patch set 4 04/29/18, 15:52

  12. TYPO3com voted on patch set 4 V +1 04/29/18, 16:04 Completed build in 11m 02s on Sun, 29 Apr, 06:04 PM Test Summary: 31061 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-22989

  13. Susi Moog voted on patch set 4 CR +1 04/29/18, 16:10

  14. Helmut Hummel voted on patch set 4 V +1 CR +1 04/29/18, 19:44

  15. Georg Ringer voted on patch set 4 V +2 CR +2 04/29/18, 20:11

  16. Georg Ringer merged patch set 5 04/29/18, 20:11