Review main Merged

56831[BUGFIX] Compatibility for finishers which set content into the response

Ralf Zimmermann CR +2 V +2 Easy +7 −0 updated 05/11/18, 14:01

Commit message

Since #83822 EXT:form makes usage of the controller context
response object which has impacts to the finisher logic which was not
treated by #83822.
Since #84495, finishers with output can return this as string instead
of setting this directly into the response
(which results in a double output).
This patch ensures that existing custom finishers which set the content
into the response, get respected.

Review

  • Code review CR +2
    • Susi Moog +2
    • Mathias Schreiber +1
    • Frank Nägler +1
    • Riny van Tiggelen +1
    • Alessandro Filira +1
  • Verified V +2
    • Susi Moog +2
    • Mathias Schreiber +1
    • Frank Nägler +1
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 1011

  1. Ralf Zimmermann uploaded patch set 1 04/30/18, 16:59

  2. TYPO3com voted on patch set 1 V +1 04/30/18, 17:07 Completed build in 07m 55s on Mon, 30 Apr, 07:07 PM Test Summary: 31061 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-22998

  3. Riny van Tiggelen voted on patch set 1 CR +1 05/01/18, 06:34

  4. Susi Moog voted on patch set 1 CR +1 05/02/18, 12:58

  5. Frank Nägler voted on patch set 1 CR +1 05/04/18, 10:31

  6. Frank Nägler voted on patch set 1 V +1 05/04/18, 10:43

  7. Alessandro Filira voted on patch set 1 CR +1 05/11/18, 13:30

  8. Mathias Schreiber voted on patch set 1 V +1 CR +1 05/11/18, 13:45

  9. Susi Moog voted on patch set 1 V +2 CR +2 05/11/18, 14:01

  10. Susi Moog merged patch set 2 05/11/18, 14:01

  11. Susi Moog commented on patch set 2 05/11/18, 14:01

    Cherry Picked This patchset was cherry picked to branch TYPO3_8-7 as commit b3bd92e9f3e57f76ed8295af9ba98fb2e51dccda