Review main Merged

56835[TASK] Inform user if TS condition does not make sense

Markus Klein CR +2 V +2 Easy +18 −0 updated 05/03/18, 06:27

Commit message

Empty conditions `[]` always evaluate to false. Warn the user
if such a condition is present.

Review

  • Code review CR +2
    • Georg Ringer +2
    • Robert Wildling +1
    • Riny van Tiggelen +1
  • Verified V +2
    • Georg Ringer +2
    • Robert Wildling +1
    • TYPO3com +1 CI

Issues 1

Files 2

Review log 912

  1. Markus Klein uploaded patch set 1 05/02/18, 22:27

  2. TYPO3com voted on patch set 1 V -1 05/02/18, 22:27 Completed build in 10s on Thu, 3 May, 12:27 AM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-23018

  3. Markus Klein uploaded patch set 2 05/02/18, 22:29

  4. TYPO3com voted on patch set 2 V -1 05/02/18, 22:39 Completed build in 09m 57s on Thu, 3 May, 12:39 AM Test Summary: 3 of 31216 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-23019

  5. Robert Wildling voted on patch set 2 V +1 CR +1 05/02/18, 22:40

  6. Markus Klein uploaded patch set 3 05/02/18, 22:44

  7. Robert Wildling voted on patch set 3 V +1 CR +1 05/02/18, 22:47

  8. TYPO3com voted on patch set 3 V +1 05/02/18, 22:54 Completed build in 09m 55s on Thu, 3 May, 12:54 AM Test Summary: 31064 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-23020

  9. Riny van Tiggelen voted on patch set 3 CR +1 05/03/18, 06:17

  10. Georg Ringer voted on patch set 3 V +2 CR +2 05/03/18, 06:27

  11. Georg Ringer merged patch set 4 05/03/18, 06:27

  12. Georg Ringer commented on patch set 4 05/03/18, 06:27

    Cherry Picked This patchset was cherry picked to branch TYPO3_8-7 as commit d01b196cc07a5cc5a77c3c34f7a2ac5e168ca779