Review TYPO3_8-7 Merged

56836[TASK] Inform user if TS condition does not make sense

Georg Ringer CR +2 V +2 Easy +15 −0 updated 05/03/18, 07:41

Commit message

Empty conditions `[]` always evaluate to false. Warn the user
if such a condition is present.

Review

  • Code review CR +2
    • Markus Klein +2
  • Verified V +2
    • Markus Klein +2
    • TYPO3com +1 CI

Issues 1

Files 2

Review log 46

  1. Georg Ringer commented on patch set 1 05/03/18, 06:27

    Cherry Picked from branch master.
  2. TYPO3com voted on patch set 1 V -1 05/03/18, 06:37 Completed build in 09m 30s on Thu, 3 May, 08:37 AM Test Summary: 6 of 58727 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC87-2358

  3. Markus Klein commented on patch set 2 05/03/18, 06:49

    Published edit on patch set 1.
  4. TYPO3com voted on patch set 2 V +1 05/03/18, 06:57 Completed build in 08m 12s on Thu, 3 May, 08:57 AM Test Summary: 58389 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC87-2359

  5. Markus Klein voted on patch set 2 V +2 CR +2 05/03/18, 07:41

  6. Markus Klein merged patch set 3 05/03/18, 07:41