Review main Merged

56856[BUGFIX] Remove duplicate database indices

Stefan Froemken CR +2 V +2 Easy +3 −5 updated 05/10/18, 17:53

Commit message

Percona toolkit found some duplicate
indices in some ext_tables.sql.
Remove or update the mentioned indices.

Review

  • Code review CR +2
    • Christian Kuhn +2
    • Mathias Schreiber +1
    • Alessandro Filira +1
  • Verified V +2
    • Christian Kuhn +2
    • Mathias Schreiber +1
    • Alessandro Filira +1
    • TYPO3com +1 CI

Issues 1

Files 3

Review log 810

  1. Stefan Froemken uploaded patch set 1 05/04/18, 07:19

  2. TYPO3com voted on patch set 1 V +1 05/04/18, 07:29 Completed build in 09m 15s on Fri, 4 May, 09:29 AM Test Summary: 31064 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-23030

  3. Martin Clewing uploaded patch set 2 05/04/18, 11:38

  4. Martin Clewing commented on patch set 2 05/04/18, 11:42

    changed commit message for a starter to get into the system
  5. TYPO3com voted on patch set 2 V +1 05/04/18, 11:46 Completed build in 08m 29s on Fri, 4 May, 01:46 PM Test Summary: 31064 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-23041

  6. Mathias Schreiber commented on patch set 2 05/04/18, 12:18

    ext_tables.sql:682

    is this the reference to "parent" that you removed?
  7. Mathias Schreiber commented on patch set 2 V +1 CR +1 05/10/18, 14:58

    ext_tables.sql:682 Reply

    Done
  8. Alessandro Filira commented on patch set 2 V +1 CR +1 05/10/18, 15:27

    I did this test: I change branch and run "Analyze Database Structure", all indices indicated in issue appeared and they was to remove. After run it, the DB analysis doesn't indicated operation to do.
  9. Christian Kuhn commented on patch set 2 V +2 CR +2 05/10/18, 17:53

    ext_tables.sql:622

    ok. looks fishy at first look, but if uid is in the query, we can expect it's a 'where uid=' due to the unique primary key nature of it.

    ext_tables.sql:154

    this is ok since key getDomainStartPage has pid at the first position.
  10. Christian Kuhn merged patch set 3 05/10/18, 17:53