56857[WIP][FEATURE] Introduce JavaScript templating engine
Commit message
Review
-
Code review CR 0
-
Verified V 0
Issues 1
Files 14
- Build/Gruntfile.js+1 −0
- Build/package.json+2 −0
- Build/yarn.lock+5 −1
- typo3/sysext/core/Resources/Private/TypeScript/Handlebars/Common.tsnew+105 −0
- typo3/sysext/core/Resources/Public/JavaScript/Contrib/handlebars.jsnew+29 −0
- typo3/sysext/core/Resources/Public/JavaScript/Handlebars/Common.jsnew+13 −0
- typo3/sysext/install/Classes/Controller/AbstractController.php+15 −1
- typo3/sysext/install/Classes/Controller/MaintenanceController.php+17 −13
- typo3/sysext/install/Resources/Private/Templates/Maintenance/ClearTables.handlebarsnew+42 −0
- typo3/sysext/install/Resources/Private/Templates/Maintenance/DatabaseAnalyzer.handlebarsnew+80 −0
- typo3/sysext/install/Resources/Private/Templates/Maintenance/DatabaseAnalyzer.htmldeleted+0 −58
- typo3/sysext/install/Resources/Public/JavaScript/Modules/ClearTables.js+7 −14
- typo3/sysext/install/Resources/Public/JavaScript/Modules/DatabaseAnalyzer.js1+23 −42
- typo3/sysext/install/Resources/Public/JavaScript/RequireJSConfig.js+2 −0
Review log 913
-
Oliver Hader uploaded patch set 1 05/04/18, 08:36
-
TYPO3com voted on patch set 1 V -1 05/04/18, 08:45 Completed build in 08m 59s on Fri, 4 May, 10:45 AM Test Summary: 31064 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-23031
-
Oliver Hader uploaded patch set 2 05/04/18, 08:56
-
TYPO3com voted on patch set 2 V -1 05/04/18, 09:06 Completed build in 09m 43s on Fri, 4 May, 11:06 AM Test Summary: 31064 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-23032
-
Oliver Hader uploaded patch set 3 05/04/18, 17:04
-
Oliver Hader updated the commit message in patch set 4 05/04/18, 17:15
-
Susi Moog uploaded patch set 5 05/05/18, 13:52
-
TYPO3com voted on patch set 5 V -1 05/05/18, 13:52 Completed build in 07s on Sat, 5 May, 03:52 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-23069
-
Susi Moog uploaded patch set 6 05/05/18, 14:05
-
TYPO3com voted on patch set 6 V +1 05/05/18, 14:13 Completed build in 07m 49s on Sat, 5 May, 04:13 PM Test Summary: 31154 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-23070
-
Tymoteusz Motylewski commented on patch set 6 05/08/18, 14:09
you have made a point. indeed the code is much more readable after introducing the handlebars. Question is whether we need client side rendering at all in these places? I would prefer to go into direction of vue.js to benefit from variable binding (angular and react are too heavy and hard to glue together with other stuff we have in BE). But we would need to create a similar proof of concept first to see if vue can play nicely with require js.DatabaseAnalyzer.js:96what is the point of fetching template source code and variables via ajax and render template client side? Why not render the whole stuff in fluid server side? -
Oliver Hader commented on patch set 6 05/10/18, 09:12
Tymek, thank for your feedback. I'd recommend not to use Vue.js with the scope of having (more or less) independent components. Vue.js requires an application wrapper to provide the according scope. Thus, I'd recommend to checkout Polymer and the basic W3C web components stack. -
Benni Mack abandoned the change 10/26/18, 10:15
no activity for 6 months, will abandon this PoC for now.