Review TYPO3_4-5 Merged

5686[BUGFIX] Race-condition while updating extension list

Steffen Gebert CR +2 V +2 Easy +2 −0 updated 06/03/13, 20:49

Commit message

There is a race-condition in the EM while updating the extension list.

If the update takes more than 30 seconds, Ext.Direct reaches its Ajax
timeout and sends the Ajax request (to update the list) again. As the EM
updates the extensions.xml.gz file at the beginning of the update
process, the second request immediately sees that the repository is
already up-to-date and respons this status to the client.

Thus, the user gets a "Repository is already up-to-date" message shown,
although it was not.

Review

  • Code review CR +2
    • Steffen Gebert +2
  • Verified V +2
    • Steffen Gebert +2

Issues 1

Files 1

Review log 3

  1. Mr. Jenkins commented on patch set 1 10/10/11, 20:51

  2. Steffen Gebert commented on patch set 1 V 0 10/10/11, 20:51

    by team member; Looks good to me, approved Review for master in I2bc6b83f0951e16b895607025c2d3bad392b9759
  3. Steffen Gebert merged patch set 1 10/10/11, 20:51