Review main Merged

56863[BUGFIX] do not override forceTypeValue if no pageType is set

Andreas Allacher CR +2 V +2 Easy +1 −1 updated 05/14/18, 14:46

Commit message

If a link doesn't set a pageType and
there is no target that defines a pageType,
then forceTypeValue needs to be used instead of always
assuming a pageType of 0.

With this fix, it is possible to actually use
the TypoScript option config.forceTypeValue again.

Review

  • Code review CR +2
    • Susi Moog +2
    • Mathias Schreiber +1
    • Tymoteusz Motylewski +1
    • Andreas Kienast +1
    • Benni Mack +1
  • Verified V +2
    • Susi Moog +2
    • Mathias Schreiber +1
    • Tymoteusz Motylewski +1
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 1114

  1. Andreas Allacher uploaded patch set 1 05/05/18, 06:29

  2. TYPO3com voted on patch set 1 V +1 05/05/18, 06:37 Completed build in 07m 58s on Sat, 5 May, 08:37 AM Test Summary: 31154 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-23067

  3. Benni Mack updated the commit message in patch set 2 05/06/18, 14:29

  4. Benni Mack voted on patch set 2 CR +1 05/06/18, 14:29

  5. TYPO3com voted on patch set 2 V -1 05/06/18, 14:39 Completed build in 09m 42s on Sun, 6 May, 04:39 PM Test Summary: 2 of 31240 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-23097

  6. TYPO3com voted on patch set 2 V +1 05/07/18, 19:36 Completed build in 5h 16m 25s on Mon, 7 May, 09:36 PM Test Summary: 30991 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-23097

  7. Tymoteusz Motylewski commented on patch set 2 05/07/18, 19:37

    Alexander, can you please provide some example configuration to reproduce the issue? thanks
  8. Andreas Kienast voted on patch set 2 CR +1 05/08/18, 07:02

  9. Andreas Allacher commented on patch set 2 05/10/18, 07:38

    Added an example to the ticket but as Benni mentioned without the patch the config options is completely ignored, there really isn't much need for it.
  10. Tymoteusz Motylewski voted on patch set 2 V +1 CR +1 05/10/18, 09:04

  11. Mathias Schreiber voted on patch set 2 V +1 CR +1 05/10/18, 11:08

  12. Susi Moog voted on patch set 2 V +2 CR +2 05/10/18, 11:12

  13. Susi Moog merged patch set 3 05/10/18, 11:12

  14. Mathias Brodala commented on patch set 3 05/14/18, 14:46

    Cherry Picked This patchset was cherry picked to branch TYPO3_8-7 as commit 9371beb3ad53584771ef369574227e99003f93b5