Review main Merged

56876[TASK] Simplify fetching section labels in global settings

Helmut Hummel CR +2 V +2 Normal +12 −101 updated 05/07/18, 06:49

Commit message

Put labels into the configuration description file
to have everything in one place.

With that in place, we can put the description directly
into the configuration data that is prepared for the edit view.

If we do so, we can get rid of the view helper
and one method in the configuration service which only
returned the labels.

Review

  • Code review CR +2
    • Georg Ringer +2
    • Benni Mack +1
  • Verified V +2
    • Georg Ringer +2
    • Benni Mack +1
    • TYPO3com +1 CI

Issues 1

Files 6

Review log 711

  1. Helmut Hummel uploaded patch set 1 05/06/18, 18:16

  2. Helmut Hummel uploaded patch set 2 05/06/18, 18:19

  3. Helmut Hummel uploaded patch set 3 05/06/18, 18:21

  4. TYPO3com voted on patch set 1 V -1 05/06/18, 18:25 Completed build in 08m 44s on Sun, 6 May, 08:25 PM Test Summary: 1 of 31239 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-23104

  5. TYPO3com voted on patch set 2 V +1 05/06/18, 18:28 Completed build in 09m 21s on Sun, 6 May, 08:28 PM Test Summary: 30991 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-23105

  6. TYPO3com voted on patch set 3 V -1 05/06/18, 18:29 Completed build in 08m 01s on Sun, 6 May, 08:29 PM Test Summary: 2 of 31240 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-23106

  7. Helmut Hummel uploaded patch set 4 05/06/18, 18:42

  8. TYPO3com voted on patch set 4 V +1 05/06/18, 18:51 Completed build in 08m 52s on Sun, 6 May, 08:51 PM Test Summary: 30991 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-23107

  9. Benni Mack voted on patch set 4 V +1 CR +1 05/07/18, 04:24

  10. Georg Ringer voted on patch set 4 V +2 CR +2 05/07/18, 06:49

  11. Georg Ringer merged patch set 5 05/07/18, 06:49