56876[TASK] Simplify fetching section labels in global settings
Commit message
Review
-
Code review CR +2
- Georg Ringer +2
- Benni Mack +1
-
Verified V +2
- Georg Ringer +2
- Benni Mack +1
- TYPO3com +1 CI
Issues 1
Files 6
- typo3/sysext/core/Configuration/DefaultConfigurationDescription.yaml+7 −0
- typo3/sysext/install/Classes/Controller/SettingsController.php+0 −1
- typo3/sysext/install/Classes/Service/LocalConfigurationValueService.php+2 −20
- typo3/sysext/install/Classes/ViewHelpers/Object/ArrayValueByKeyViewHelper.phpdeleted+0 −75
- typo3/sysext/install/Resources/Private/Partials/Settings/LocalConfiguration/SubSection.html+2 −4
- typo3/sysext/install/Resources/Private/Templates/Settings/LocalConfigurationGetContent.html+1 −1
Review log 711
-
Helmut Hummel uploaded patch set 1 05/06/18, 18:16
-
Helmut Hummel uploaded patch set 2 05/06/18, 18:19
-
Helmut Hummel uploaded patch set 3 05/06/18, 18:21
-
TYPO3com voted on patch set 1 V -1 05/06/18, 18:25 Completed build in 08m 44s on Sun, 6 May, 08:25 PM Test Summary: 1 of 31239 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-23104
-
TYPO3com voted on patch set 2 V +1 05/06/18, 18:28 Completed build in 09m 21s on Sun, 6 May, 08:28 PM Test Summary: 30991 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-23105
-
TYPO3com voted on patch set 3 V -1 05/06/18, 18:29 Completed build in 08m 01s on Sun, 6 May, 08:29 PM Test Summary: 2 of 31240 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-23106
-
Helmut Hummel uploaded patch set 4 05/06/18, 18:42
-
TYPO3com voted on patch set 4 V +1 05/06/18, 18:51 Completed build in 08m 52s on Sun, 6 May, 08:51 PM Test Summary: 30991 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-23107
-
Benni Mack voted on patch set 4 V +1 CR +1 05/07/18, 04:24
-
Georg Ringer voted on patch set 4 V +2 CR +2 05/07/18, 06:49
-
Georg Ringer merged patch set 5 05/07/18, 06:49