Review main Merged

56881[BUGFIX] Correctly resolve RTE preset configuration for link browser

Jan Stockfisch CR +2 V +2 Easy +10 −1 updated 06/01/18, 09:25

Commit message

Replaces hardcoded RTE configuration in BrowseLinksController
with one resolved by Formengine when rendering a field.
This takes into account e.g. column overrides.

The RTE configuration preset name is now kept by Formengine in
['processedTca']['columns'][$fieldName]['config']['richtextConfigurationName']

Then it's being passed as parameter P[richtextConfigurationName] from RTE field
to the BrowseinksController

Review

  • Code review CR +2
    • Tymoteusz Motylewski +2
    • Jan Stockfisch +1
    • Christian Kuhn +1
  • Verified V +2
    • Tymoteusz Motylewski +2
    • Jan Stockfisch +1
    • Christian Kuhn +1
    • TYPO3com +1 CI

Issues 1

Files 4

Review log 2633

Show 68 earlier messages
  1. Jan Stockfisch uploaded patch set 1 05/07/18, 13:04

  2. TYPO3com voted on patch set 1 V -1 05/07/18, 13:17 Completed build in 12m 44s on Mon, 7 May, 03:17 PM Test Summary: 1 of 31239 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-23119

  3. TYPO3com voted on patch set 1 V +1 05/07/18, 13:23 Completed build in 31m 15s on Mon, 7 May, 03:23 PM Test Summary: 30991 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-23119

  4. Tymoteusz Motylewski voted on patch set 1 CR +1 05/07/18, 17:59

  5. Christian Kuhn commented on patch set 1 CR -1 05/07/18, 18:02

    BrowseLinksController.php:578

    quite frankly, i'm not entirely sure if that is a good idea. need to be checked, may have funny side effects depending on context / scope, for instance if within a flex form field?
  6. Jan Stockfisch commented on patch set 1 05/08/18, 07:20

    BrowseLinksController.php:578 Reply

    suggestion how we would handle these cases?
  7. Tymoteusz Motylewski commented on patch set 1 CR 0 05/11/18, 21:09

    One way would be to process the filed dataproviders in the same way formengine does. This way we would get all the required data prepared for us.
  8. Tymoteusz Motylewski commented on patch set 1 05/11/18, 21:14

    On the other hand it might be overcomplicated
  1. Jan Stockfisch commented on patch set 1 05/14/18, 10:33

    > On the other hand it might be overcomplicated For this only case - yes. IMHO I would like to see this kind of thing done in a general service or utility, which processes all data providers. But I guess replacing all static calls with this service would take waaay to much resources and time.
  2. Tymoteusz Motylewski commented on patch set 1 05/21/18, 21:43

    did some research: - the patch improves situation for normal fields, as now you can use columnOverride to pass custom richtextConfiguration preset (which is the only TCA config RTE cares about in Richtext->getConfiguration() - in case of the flex form field, the $tcaFieldConf contains sth like: ‌array ( 'type' => 'flex', 'ds' => array ( 'default' => ' <T3DataStructure> <sheets> .... So, it's not very helpful. Ideally the curent flex field configuration should be extracted from the DS, to make use of the <richtextConfiguration> somebody set in the DS. AFAIK (Lolli, please correct me if I'm wrong) it is NOT possible to override flexfrom configuration using columnOverrides. So no need for config merging in case of the flex. On the other hand the current patch is not breaking/or making situation worse for flexforms. - What is also worth mentioning that for both, real fields and flex fields it is possible to override RTE configuration from PageTS, which sounds like a good alternative for columnOverride. Next steps: - It would be nice to make the patch complete by adding flex handling (extracting field configuration from DS) - a proper testing with EXT:styleguide and rte inside inline relations, flex and friends has to be performed, to make sure we don't breake sth in the process
  3. Jan Stockfisch commented on patch set 1 05/28/18, 09:05

    > - What is also worth mentioning that for both, real fields and flex > fields it is possible to override RTE configuration from PageTS, > which sounds like a good alternative for columnOverride. Sounds more and more to me that the BrowseLinksController is not the place, where the field configuration should be resolved in the first place. I'm not feeling well with adding this much business logic to a controller. It seems to me that resolving the final TCA field config is a problem in general.
  4. Tymoteusz Motylewski commented on patch set 1 05/28/18, 13:22

    From my POV we can continue with the patch without flexform support (as the patch is not making the issue worse for flexforms, but fixes the issue for other fields)
  5. Jan Stockfisch commented on patch set 1 05/28/18, 14:57

    At this moment, FlexForm isn't supported at all. I mean, like: If you use FlexForm, your RTE will broken - there is no fallback. I just went for the TCA and missed the FlexForm point. I'll add a default fallback asap.
  6. Christian Kuhn commented on patch set 1 05/28/18, 21:27

    talked with tymek about this patch, he will change the solution a bit and come up with an approach to handle it in a slightly different way.
  7. Tymoteusz Motylewski commented on patch set 1 CR -1 05/28/18, 22:00

    on it
  8. Tymoteusz Motylewski uploaded patch set 2 05/28/18, 23:04

  9. TYPO3com voted on patch set 2 V +1 05/28/18, 23:12 Completed build in 07m 59s on Tue, 29 May, 01:12 AM Test Summary: 31122 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-23854

  10. Christian Kuhn commented on patch set 2 CR -1 05/29/18, 20:27

    way to go, but tymek will change a minor detail again.
  11. Tymoteusz Motylewski uploaded patch set 3 05/29/18, 20:57

  12. Christian Kuhn commented on patch set 3 V +1 CR +1 05/29/18, 21:03

    Jan do you want to re-test this solution on your side?
  13. Christian Kuhn commented on patch set 3 05/29/18, 21:04

    Jan do you want to re-test this solution on your side?
  14. TYPO3com voted on patch set 3 V -1 05/29/18, 21:05 Completed build in 07m 44s on Tue, 29 May, 11:05 PM Test Summary: 2510 of 31369 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-23879

  15. Tymoteusz Motylewski uploaded patch set 4 05/29/18, 22:24

  16. TYPO3com voted on patch set 4 V -1 05/29/18, 22:33 Completed build in 08m 23s on Wed, 30 May, 12:33 AM Test Summary: 2603 of 31369 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-23890

  17. Tymoteusz Motylewski uploaded patch set 5 05/29/18, 22:39

  18. Tymoteusz Motylewski uploaded patch set 6 05/29/18, 22:40

  19. TYPO3com voted on patch set 5 V -1 05/29/18, 22:46 Completed build in 07m 18s on Wed, 30 May, 12:46 AM Test Summary: 3 of 31369 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-23891

  20. TYPO3com voted on patch set 6 V +1 05/29/18, 22:49 Completed build in 08m 40s on Wed, 30 May, 12:49 AM Test Summary: 31122 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-23892

  21. Christian Kuhn voted on patch set 6 V +1 CR +1 05/29/18, 23:01

  22. Jan Stockfisch voted on patch set 6 V +1 CR +1 06/01/18, 09:11

  23. Tymoteusz Motylewski voted on patch set 6 V +2 CR +2 06/01/18, 09:23

  24. Tymoteusz Motylewski merged patch set 7 06/01/18, 09:23

  25. Tymoteusz Motylewski commented on patch set 7 06/01/18, 09:25

    Cherry Picked This patchset was cherry picked to branch TYPO3_8-7 as commit d75a76cfb218fa32f0092aa12c10df9693d80789